Skip to content

SWHC008 update following 2025 Title 24 codes file update#104

Open
simularis wants to merge 57 commits intosound-data:mainfrom
simularis:SWHC008-T24-update
Open

SWHC008 update following 2025 Title 24 codes file update#104
simularis wants to merge 57 commits intosound-data:mainfrom
simularis:SWHC008-T24-update

Conversation

@simularis
Copy link
Copy Markdown
Contributor

@simularis simularis commented Apr 30, 2025 •
edited
Loading

Pull Request (PR) Description

Measure update:

Repo owner

  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Assign reviewer.

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure. included in measure folder
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions. Communicated via eTRM and emails
  • For a new measure, add a summary table showing total energy consumption per simulated case. Communicated via eTRM and emails

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

Internal PR review was conducted by Solaris Technical team at simularis#17 and simularis#44.

Internal review comments:

  • In cw.pxt template, the original setup for SWHC008 included changing Pump Control Type from Continuous to Intermittent. The change should be wrapped in logic to preserve default behavior in other measures, or submitted as a separate pull request. 12/31/2025: resolved
  • Could benefit from README file for special post-processing instructions 12/31/2025: resolved

Reviewer wishlist (not important):

  • SWHC008-03 folder was moved rather than duplicated
  • For future enhancement: move the lookup tables for CW pump min flow rate from codes files to another CSV file, but this requires developing a new capability in the rakefile.

Afshin Faramarzi and others added 30 commits April 15, 2024 14:42
Changes for condenser loop in order to model constant speed and
2b75997 
variable speed

-added min flow rate parameter
-added schedule and setpoint manager for min flow rate.
-revised code to include VS pump when we have VS cooling tower.
-Changed the pump control type from intermittent to continuous.
-Added pump flow rate to output variable.

Explanations: Based on eTRM we need to have min flow rate in condeser loop
of measure case, So I added the related parameters.
Renamed TechIDs based on DEER template
ea1a5aa
- Renamed folders
0600c11
- Changing the folder names
10a4e2e
-Removing unnecessary folders
027af1a
-Replacing updated query files
7337535
-Renaming Cohorts name to be compatible to Com.py
e9e030d
-Renaming cohort file name
644a77f
-Renaming cohort names
7a4afab
-Updating case names
416588b
-Updating case names
95766ac
-Including missing prototypes in cohort file
a6b0e93
Merge branch 'simularis_main' into dev-SWHC008-T24-update
39cd89b
Updating to 2025 T24 code files
2718b8f
Deleted unsed case files
9480049
Update cohorts.csv files
94fd5b1
Update climates.csv files
6918b61
Added DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx
6e78dbb
Update cx.pxt and custom.pxt
4fc1af7
Revert "Added DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx"
4ba44db 
This reverts commit 6e78dbb.
Added DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx to measure f…
57e53ea 
…older
Update cohort names to match case files
a8cffbe
Update Com.py
21cd9f1
Label output variables on custom.pxt
062a51c
Update to measure-specific query file
26a6331
Post-processing - simdata.csv
073f0ee
Post-processing - results-sizing-agg.csv and results-sizing-detail.csv
11f9790
Rename folder version
47ddb52
Revert "Update Com.py"
32557ee 
This reverts commit 21cd9f1.
Revert "Post-processing - simdata.csv"
22def7d 
This reverts commit 073f0ee.

# Conflicts:
#	commercial measures/SWHC008-04 VSD Central Plant/result2.py
#	commercial measures/SWHC008-04 VSD Central Plant/simdata.csv
J Moon and others added 9 commits April 21, 2025 10:34
Result.py
5e24c1f
Result2.py
af38e78
@simularis
Merge pull request #17 from unbiya/dev-SWHC008-T24-update
defa789 
Develop SWHC008 T24 Update

- Apply 2025 Title 24 updates to SWHC008
- New folder: commercial measures/SWHC008-04 VSD Central Plant

Issues remaining:
- SWHC008-03 folder was moved rather than duplicated
- Could benefit from README file for special post-processing instructions
@nfette
Restore default behavior cw pump control type (only affected SWHC008)
b64bb3b
@nfette
Apply continuous CW pumpt control via parameter in SWHC008
4e0ecc2
@nfette
Documentation for CW pump min flow rate in SWHC008
055e6bc
@nfette
Revert testing change
fce9633
@behzadsalimian
New parameter "pump_type" was added to control condenser water pump s…
c1af163 
…peed independently of tower type
@behzadsalimian
Added pump type parameter to the cases file
e6c4f0e
@nfette nfette force-pushed the SWHC008-T24-update branch from de31668 to defa789 Compare November 13, 2025 16:36
@simularis
Copy link
Copy Markdown
Contributor Author

simularis commented Dec 17, 2025

Additional changes are pending completion of internal review at simularis#44

@simularis simularis marked this pull request as draft December 17, 2025 01:01
nfette and others added 7 commits December 30, 2025 09:53
@nfette
Clarify CW min pump flow data source and update pump_min_flow.csv
08f090c
@nfette
Create README for SWHC008
e45f3ba
@behzadsalimian
Uncommented all the climate zones
a3f7b81
@behzadsalimian
Revised comments on the cases files
4523a7d
@behzadsalimian
Revised comments lines in the cases files
e28d4bb
@behzadsalimian
Merge branch 'dev-SWHC008-cpuc-review1' of https://github.com/simular…
a192ae6 
…is/DEER-Prototypes-EnergyPlus.git into dev-SWHC008-cpuc-review1
@simularis
Merge pull request #44 from simularis/dev-SWHC008-cpuc-review1
feb0aa5 
SWHC008-04 revision 1 based on CPUC review

- Implement lookup table for CW pump minimum flow rate as a function of building type and climate zone (using codes files)
- Add explicit pump_type parameter in cw.pxt to control condenser pump type independently of cooling tower count, preserving original behavior by default
- Parameterize CW pump control type and restore default behavior to template
- Decouple pump VFD logic from cooling tower fan speed control to ensure SWHC008 savings reflect pump-only impacts.
 Implemented climate- and building-specific CW pump minimum flow lookup tables in "T24_weight_averaged_ex.csv", "T24_weight_averaged_ex_Htl.csv", "T24_2025_new.csv", and "T24_2025_new_Htl.csv" with documentation notes for transparency.
- Implement an EMS-based minimum CW flow control option to enforce 70% of autosized design flow during cooling load while allowing pump shutoff at no load.
- Implement min_flowrate_fraction parameter to support alternate approach to minimum flow turndown for variable-speed condenser pumps (unused in SWHC008)
- Document units of measure for CW min pump flow parameter
- Document values and source of calculation for CW min pump flow
- Create a README.md to describe any unusual steps required to reproduce the models, normalizing units, or unit energy savings
@simularis simularis marked this pull request as ready for review December 31, 2025 23:42
@simularis
Copy link
Copy Markdown
Contributor Author

simularis commented Dec 31, 2025

Measure developer committed all changes from CPUC review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simularis @nfette @behzadsalimian @janiksomaiya