Minor typographical errors and some rewriting.#17
Minor typographical errors and some rewriting.#17quakeulf wants to merge 1 commit intosostel:190612-ETDocsUpdatefrom
Conversation
I've wanted to help out earlier but had no time. I went over the documentation to fix a few issues I saw that could help make it read easier to read by making it less verbose. I hope these changes are ok.
| The samples let you experience one of our new magical input capabilities: **Eye tracking**! | ||
| The demo includes a number of different use cases ranging from implicit eye-based activations to how to seamlessly combine information about what you are looking at with **voice** and **hand** input. | ||
|
|
||
| The demo includes a number of different use cases ranging from implicit eye-based activations, to how to seamlessly combine information about what you are looking at with **voice** and **hand** input. |
There was a problem hiding this comment.
Why would you add a comma between "range from ... to ..."?
| Please beware though that the _simulated eye gaze_ via mouse control is a rather poor supplement to our rapid and unintentional eye movements. | ||
| It's great for testing the basic functionality though before iterating on the design by deploying it to the HoloLens 2 device. | ||
| Coming back to our sample scene: The gem rotates as long as being looked at and can be destroyed by "looking" at it and ... | ||
| Please be aware that the _simulated eye gaze_ via mouse control is a rather poor supplement to our rapid and unintentional eye movements. |
There was a problem hiding this comment.
Beware was chosen intentionally as it indicates a risk that the user should be aware of.
There was a problem hiding this comment.
But if it is a risk the user should be aware of then why not use "be aware"? Besides, "beware" implicates danger.
sostel
left a comment
sostel
left a comment
There was a problem hiding this comment.
Thanks for reading through it and the suggested changes. There are a few things that I've commented on. Also, please note that this is currently work-in-progress, in case you're planning to check out the other docs as well.
|
I specifically went for eye-related documentation as it is relevant to what we want to do in future projects and because it is WIP. |
|
Sorry, I clicked one "resolve" too much and github is having issues with letting me change. |
2 participants
Overview
I've wanted to help out earlier but had no time. I went over the documentation to fix a few issues I saw that could help make it read easier to read by making it less verbose. I hope these changes are ok.
Changes