-
Notifications
You must be signed in to change notification settings - Fork 34
CI: NDK r28+ and native libs verification #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Summary
Why
What To Look For
How To Validate Locally
Notes
|
SDILogin
previously approved these changes
Sep 1, 2025
Contributor
Author
Summary
Why
Validation
How Reviewers Can Verify
Notes
|
SDILogin
previously approved these changes
Sep 1, 2025
…set to empty string)
disable Gradle parallel in Jenkins
SDILogin
reviewed
Sep 2, 2025
…ug/debug/assemble) remove unintended lifecycle deps (ksp lifecycle compiler, viewmodel-ktx)
SDILogin
reviewed
Sep 2, 2025
SDILogin
reviewed
Sep 2, 2025
SDILogin
previously approved these changes
Sep 2, 2025
SDILogin
approved these changes
Sep 2, 2025
This was referenced Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Install NDK 28.0.12674087 (default), keep 25.2 for utils. Export NDK env to r28, print revision, and verify native libs via readelf
Related Issue
Closes # (or) Relates to #
Type of Change
Screenshots / Videos
If UI changes, include before/after.
Test Plan
Commands run locally:
./gradlew detektAll
./gradlew runTest
./gradlew :app:lint
Additional checks and scenarios covered:
readelf on native libs
Risks & Rollout
Potential impact, migrations, or config/secrets required.
installed)
Checklist
EOF
[x] Ran detektAll, runTest, and :app:lint locally (or via CI)
[x] No secrets or local.properties committed