Use YAML.safe_load_file instead of YAML.load_file#15
Open
akihiro17 wants to merge 1 commit intosorah:masterfrom
Open
Use YAML.safe_load_file instead of YAML.load_file#15akihiro17 wants to merge 1 commit intosorah:masterfrom
akihiro17 wants to merge 1 commit intosorah:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into the following error when I set up the SSH proxy with
Net::SSH::Proxy::Jumpin Ruby 3.1.sample yaml
error
This is because Ruby 3.1, with Psych 4.0.0, introduces breaking changes to
YAML.load_file.ref. https://bugs.ruby-lang.org/issues/17866
ref. https://techlife.cookpad.com/entry/2021/12/25/220002
In this PR, I changed the code to use
YAML.safe_load_fileinstead ofYAML.load_fileand specifiedpermitted_classes. I confirmed that it worked on Ruby 3.1 with the ssh proxy ofNet::SSH::Proxy::Jump, but I haven't confirmed its behavior in other cases.error when
YAML.safe_load_filepermitsNet::SSH::Proxy::JumpandNet::SSH::Proxy::Command