Skip to content

finish#46

Merged
hyun-hyang merged 37 commits intodevfrom
model
Jun 16, 2025
Merged

finish#46
hyun-hyang merged 37 commits intodevfrom
model

Conversation

@hyun-hyang
Copy link
Copy Markdown
Contributor

No description provided.

@hyun-hyang hyun-hyang requested a review from Copilot June 16, 2025 15:22
@hyun-hyang hyun-hyang merged commit b166c47 into dev Jun 16, 2025
2 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR finalizes various improvements to the Papers and Graph services. Key changes include updates to dependencies (adding httpx, aioredis, etc.), refactoring synchronous calls into asynchronous operations (improving Redis and HTTP call handling), and streamlining the codebase by removing obsolete dummy data and updating Docker/runtime configurations.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
app/services/papers_service/requirements.txt Added httpx dependency.
app/services/papers_service/papers_service.py Refactored imports and API endpoints to use async operations.
app/services/papers_service/data/dummy_data.py,
data/kw2pids.json
Removed obsolete dummy and cache data files.
app/services/graph_service/* Updated requirements, integrated async HTTP client and Redis caching, and adjusted API endpoints.
app/runtime/* Updated Dockerfiles, startup scripts, API defaults, and refactored graph construction logic.
app/services/get_meta.py Added new async meta fetching functions.
Comments suppressed due to low confidence (1)

app/runtime/graph_builder.py:175

  • The variable 'hop1' is used when initializing the node for depth-1 keywords but is not defined within the loop. Please ensure that 'hop1' is properly assigned before being used.
"pids":    hop1,          # 필요 없으면 제거

Comment on lines +39 to +41
print(f"✅ Connected to Redis at {REDIS_URL}")
except Exception as e:
print(f"⚠️ Redis 연결 실패, 캐시 미사용: {e}")
Copy link

Copilot AI Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The startup event now uses print statements for logging Redis connection status; consider reverting to a consistent logging framework (e.g., using logger.info) to maintain uniform logging throughout the project.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants