Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR finalizes various improvements to the Papers and Graph services. Key changes include updates to dependencies (adding httpx, aioredis, etc.), refactoring synchronous calls into asynchronous operations (improving Redis and HTTP call handling), and streamlining the codebase by removing obsolete dummy data and updating Docker/runtime configurations.
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/services/papers_service/requirements.txt | Added httpx dependency. |
| app/services/papers_service/papers_service.py | Refactored imports and API endpoints to use async operations. |
| app/services/papers_service/data/dummy_data.py, data/kw2pids.json |
Removed obsolete dummy and cache data files. |
| app/services/graph_service/* | Updated requirements, integrated async HTTP client and Redis caching, and adjusted API endpoints. |
| app/runtime/* | Updated Dockerfiles, startup scripts, API defaults, and refactored graph construction logic. |
| app/services/get_meta.py | Added new async meta fetching functions. |
Comments suppressed due to low confidence (1)
app/runtime/graph_builder.py:175
- The variable 'hop1' is used when initializing the node for depth-1 keywords but is not defined within the loop. Please ensure that 'hop1' is properly assigned before being used.
"pids": hop1, # 필요 없으면 제거
| print(f"✅ Connected to Redis at {REDIS_URL}") | ||
| except Exception as e: | ||
| print(f"⚠️ Redis 연결 실패, 캐시 미사용: {e}") |
There was a problem hiding this comment.
[nitpick] The startup event now uses print statements for logging Redis connection status; consider reverting to a consistent logging framework (e.g., using logger.info) to maintain uniform logging throughout the project.
No description provided.