Skip to content

Conversation

@pablomh
Copy link
Contributor

@pablomh pablomh commented Jan 20, 2021

In my testing I run into this, which wasn't caught properly:

. . .
Merging arch/arm64/configs/sony/android-extra.config
The merge file 'arch/arm64/configs/sony/android-extra.config' does not exist.  Exit

…g files

In my testing I run into this, which wasn't caught properly:

. . .
Merging arch/arm64/configs/sony/android-extra.config
The merge file 'arch/arm64/configs/sony/android-extra.config' does not exist.  Exit
@MarijnS95
Copy link
Contributor

MarijnS95 commented Jan 20, 2021

@pablomh These programs should terminate with a non-zero exit code, right?

Any idea why we're capturing output here and not checking exit code instead?

ie. afaik something like if ! ret=$(the invocation); then echo "Failed with $ret"; exit 1; fi should work, right? Would you be able to test that and remove all these fault-intolerant *error* matches?

@pablomh pablomh changed the title [LA.UM.7.1.r1] Cope with the non-existence of some of the confiig files [LA.UM.7.1.r1] Cope with the non-existence of some of the config files Jan 20, 2021
@pablomh
Copy link
Contributor Author

pablomh commented Jan 20, 2021

I'm just following the existing code style :/

I agree that it's ugly but didn't want to touch it that much.

@MarijnS95
Copy link
Contributor

@pablomh No worries, I was just hoping if you could test and improve the situation :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants