Update ENCAP_U1 functionality by u1_* headers emission and u1_ipv4 checksum #683
+86
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecksum update - Added emission of all u1_* headers in dash_deparser so U1 encapsulation is serialized into the outgoing packet. - Added IPv4 checksum update for hdr.u1_ipv4 alongside hdr.u0_ipv4. - Restored and fixed saidashflow-FlowHitActionEncapU0EncapU1 test to validate double encapsulation packet formation. ENCAP_U1 logic was missing components (header emission and checksum) prevented correct packet output. This change updates the ENCAP_U1 functionality and also updates the test coverage. Signed-off-by: Farhan Tariq <farhantariq1016@gmail.com>
The committers listed above are authorized under a signed CLA. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 683 in repo sonic-net/DASH |
Collaborator
Collaborator
Collaborator
|
hi @marian-pritsak and/or @oleksandrivantsiv - would you be able to review this one by chance please? |
Collaborator
|
hi @marian-pritsak - would you be able to do a review for @prsunny for this one pls? |
marian-pritsak
approved these changes
Nov 18, 2025
Collaborator
|
hey @prsunny and @prabhataravind - Marian approved these changes, can we Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the ENCAP_U1 functionality in the DASH pipeline by adding the missing deparser emission for u1_* headers and IPv4 checksum update for u1_ipv4.
These updates were made while fixing the saidashflow test case for double encapsulation (ENCAP_U0 | ENCAP_U1), which was failing due to incomplete U1 packet output.
Background
The pipeline’s logic for ENCAP_U1 already existed, but packets generated for ENCAP_U0 | ENCAP_U1 flows were missing the U1 encapsulation layer because:
As a result, the FlowHitActionEncapU0EncapU1 test failed and was disabled.