fix: align cypher node labels and improve skill routing reliability#71
Merged
fix: align cypher node labels and improve skill routing reliability#71
Conversation
Add explicit cypher query examples and a CRITICAL instruction to use execute_cypher for all result retrieval. Models were bypassing cypher and reading /tmp/patent-search-*.json with python3, causing redundant file reads and wasted time. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace runner.sh and tools/*.sh with skill-bench CLI native TOML format. Move test cases from agents/skill-bench/cases/ to tests/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename patents array key to "Patent" in SearchResult/JS/serde to match cypher-rs label derivation from array key - Add total_results, top_assignees, top_cpcs to SearchResultSummary so models receive metadata without reading JSON files - Update skill descriptions with "Always use this skill" phrasing to prevent models from bypassing skills to call MCP tools directly - Fix test assertions from tool-use to tool-param for parameter checks - Change assignee-check test company from Google/Toyota to Salesforce to reduce unnecessary follow-up searches Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sonesuke
added a commit
that referenced
this pull request
Mar 30, 2026
Breaking changes (from #71): - SearchResult.patents JSON key renamed from "patents" to "Patent" - SearchResultSummary adds new fields (total_results, top_assignees, top_cpcs) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sonesuke
added a commit
that referenced
this pull request
Mar 30, 2026
Breaking changes (from #71): - SearchResult.patents JSON key renamed from "patents" to "Patent" - SearchResultSummary adds new fields (total_results, top_assignees, top_cpcs) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sonesuke
added a commit
that referenced
this pull request
Mar 30, 2026
Breaking changes (from #71): - SearchResult.patents JSON key renamed from "patents" to "Patent" - SearchResultSummary adds new fields (total_results, top_assignees, top_cpcs) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sonesuke
added a commit
that referenced
this pull request
Mar 30, 2026
Breaking changes (from #71): - SearchResult.patents JSON key renamed from "patents" to "Patent" - SearchResultSummary adds new fields (total_results, top_assignees, top_cpcs) Co-authored-by: sonesuke <sonesuke@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patents→Patentin SearchResult JSON key, serde, and JS extractor so cypher-rs derives:Patentlabel from the array keytotal_results,top_assignees,top_cpcstoSearchResultSummaryMCP response — models no longer need to read JSON files for metadatatool-use→tool-paramfor parameter value checks (requires skill-bench PR build: setup ci, devcontainer and task runner #21)Dependencies
tool-paramassertion fixTest plan
cargo testpassesmise run skill-test: 10/11 pass (functional-filing is flaky due to model non-determinism)🤖 Generated with Claude Code