Add the possibility to use multiple FQDN#198
Open
grimlokason wants to merge 5 commits intosonatype:mainfrom
Open
Add the possibility to use multiple FQDN#198grimlokason wants to merge 5 commits intosonatype:mainfrom
grimlokason wants to merge 5 commits intosonatype:mainfrom
Conversation
add the possibility to use multiple FQDN on UI and Docker registries
Add multiHost for multiple FQDN for UI and registries in values.yaml
Add information about the hostMulti in README.md
correct default values for ingress.hostMulti and nexus.docker.registries[0].hostMulti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This change add the possibility to use multiple FQDN for the UI and the docker registries
This is done by adding a new array ( hostMulti ) for each docker repo and ingress with all the FQDN needed.
The add of a new array instead of using the original var is here to avoid breaking conf that are actually working and don't need that function.
NB : we are on traefik and it worked, we don't have nginx as an ingress.
Best regards.
Things to Do Before Submitting
Have you signed the Sonatype CLA?
Yes under the name Youenn Gestin
Have you added and run automated tests for your change?
(See the README)
I'm sorry, i'm not accostumated to that.
I've runned it but not added some since i don't know how to automatically validate the change.
helm linton your change?yes, the lint is ok :
( NB : i'll be away from 30th april to 9th may )