fix(security): Remove hardcoded default IQ Server credentials#289
fix(security): Remove hardcoded default IQ Server credentials#289abhu85 wants to merge 1 commit intosonatype-nexus-community:mainfrom
Conversation
|
Thanks for the contribution. Unfortunately some of your commits don't meet our standards. All commits must be signed and have author information set. The commits to review are:
See Signed Commits. |
a75714c to
7d6bdf1
Compare
|
Thanks for the contribution. Before we can merge this, we need @abhu85 to sign the Contributor License Agreement |
7d6bdf1 to
f702aa1
Compare
|
Thanks for the PR @abhu85 - but for Sonatype Community Projects we require all commits to be signed - please see https://contribute.sonatype.com. |
f702aa1 to
18f7f0e
Compare
BREAKING CHANGE: IQ Server credentials are now required Security fixes: - Remove hardcoded default username 'admin' (CWE-798) - Remove hardcoded default token 'admin123' (CWE-798) - Remove default server URL 'http://localhost:8070' - Add credential validation before IQ Server communication - Mark iq-server-url as required flag Users must now provide credentials via: - CLI flags: --iq-username, --iq-token, --iq-server-url - Environment variables: IQ_USERNAME, IQ_TOKEN, IQ_SERVER - Config file: ~/.iqserver/.iq-server-config Fixes sonatype-nexus-community#288 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
18f7f0e to
7d9e066
Compare
|
|
Hi, I've updated the commit with a verified signature. The commit is now signed with my SSH signing key registered on GitHub. Could you please re-run the verification check? Thank you! |
|
@madpah Thanks for the heads up! I've now signed the commit with my SSH signing key that's registered on my GitHub account. The commit should show as "Verified" now. Please let me know if there's anything else needed. |



Summary
This PR addresses security vulnerabilities related to hardcoded default credentials in nancy.
Security Fixes
adminadmin123Breaking Changes
IQ Server credentials are now required and must be provided via one of:
--iq-username,--iq-token,--iq-server-urlIQ_USERNAME,IQ_TOKEN,IQ_SERVER~/.iqserver/.iq-server-configFiles Changed
internal/cmd/iq.go- Removed hardcoded defaults, added validationTesting
Fixes #288
Generated with Claude Code