Apply fixes from StyleCI #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
somework
merged commit 115356e
into
codex/analyze-pagination-behavior-and-test-design
7 checks passed
somework
added a commit
that referenced
this pull request
Dec 5, 2025
…-based returns (#7) * Harden adapter validation and loop safety * style: implement Yoda comparison style across codebase - Add yoda_style rule to PHP-CS-Fixer configuration - Convert all comparison operators to Yoda style (0 === $value) - Applied to src/, tests/ directories - Prevents accidental assignment bugs in conditionals - Maintains consistent coding style throughout project * feat: implement comprehensive exception architecture Complete exception architecture refactoring with enterprise-grade exception system: - NEW: PaginationExceptionInterface extending Throwable for type safety - NEW: PaginationException, InvalidPaginationArgumentException, InvalidPaginationResultException - IMPROVED: Rich contextual error messages with parameter values and actionable guidance - UPDATED: All core classes and interfaces to use new exception hierarchy - TESTED: 102 tests with comprehensive exception scenario coverage - QUALITY: Zero PHPStan errors, full PSR-12 compliance, backward compatible This transforms the pagination package into a production-ready library. * feat: complete exception architecture integration Updated all core classes and tests to use new exception architecture: - OffsetAdapter: Enhanced validation with detailed InvalidPaginationArgumentException - OffsetResult: Result validation with InvalidPaginationResultException - Source adapters: Callback validation with contextual error messages - Interfaces: Added exception documentation to PHPDoc - Test suite: Updated 102 tests with new exception expectations Quality: Zero PHPStan errors, 10,498 assertions, backward compatible * refactor: enhance type safety and test organization - Enhance SourceInterface with positive-int types for better static analysis - Reorganize OffsetAdapterTest methods for logical test flow - Restructure OffsetResultTest with improved method grouping - Optimize PropertyBasedTest method ordering for clarity - Maintain full backward compatibility and test coverage Quality: 96 tests passing, zero static analysis errors * docs: fix CHANGELOG versioning - separate 2.0.0 and 3.0.0 releases - Move PHP 8.2 migration changes to version 2.0.0 - Create version 3.0.0 for pagination analysis and architecture improvements - Properly categorize breaking changes, new features, and improvements - Follow semantic versioning principles for major version bumps * docs: update README for v3.0.0 architecture changes - Remove SourceResultInterface references and examples - Update basic usage examples to show direct Generator returns - Add advanced features section (exceptions, static factories, generators) - Include migration guide for v2.x to v3.0 breaking changes - Document new exception hierarchy and error handling - Update custom source implementation examples - Add information about enhanced type safety and validation * feat: enhance developer experience and Packagist discoverability 🔧 API Improvements: - Add OffsetAdapter::fromCallback() static factory for convenient callback-based setup - Add OffsetAdapter::fetchAll() convenience method for direct array results - Enhance SourceCallbackAdapter documentation and discoverability - Improve inline documentation across all public APIs 📚 Documentation Overhaul: - Completely rewrite README.md with compelling hero section and 30-second quickstart - Extract migration guide to dedicated UPGRADE.md file for better organization - Create comprehensive CONTRIBUTING.md with development setup and guidelines - Structure documentation for different audiences (users, contributors, upgraders) 📦 Packagist Optimization: - Optimize composer.json description for SEO with key search terms - Add 15+ relevant keywords for better discoverability - Enhance package metadata with homepage and support links 🛠️ Quality & CI Enhancements: - Configure CI artifact uploads for test results and coverage reports - Add PHPUnit JUnit logging for better test result visualization - Update .gitignore to exclude build artifacts - Maintain strict code quality standards (PHPStan level 9, PSR-12) 🎯 Developer Experience: - Transform package from functional library to discoverable, easy-to-use solution - Reduce onboarding time from complex setup to 30-second copy-paste - Position as clear alternative to manual pagination implementations - Framework-agnostic design with modern PHP 8.2+ features * Apply fixes from StyleCI (#9) Co-authored-by: Igor Pinchuk <somework@users.noreply.github.com> * fix: enable Xdebug for code coverage in CI - Enable Xdebug in composer-install action (coverage: xdebug) - Make coverage artifact upload conditional on success - Ensure coverage reports are properly generated in CI pipeline Resolves PHPUnit warning: 'No code coverage driver available' * fix: address CodeRabbit review comments - README: Fix streaming example to use strict null check instead of truthy check - OffsetResult: Remove unused InvalidPaginationResultException import - OffsetResult: Remove incorrect @throws annotation from fetchAll() method - SourceInterface: Update @param types from positive-int to int to match actual contract - PropertyBasedTest: Fix callback signatures to accept required (int $page, int $pageSize) parameters - Style: Auto-fix code formatting with CS fixer All tests pass (96/96) and quality checks pass. * polish: address final CodeRabbit review suggestions Code Quality & Clarity: - Simplify ArraySource ternary to if-statement for better readability - Add safety guard to prevent infinite loops in IntegrationTest - Clarify nowCount parameter behavior with detailed comments - Use yield from [] consistently for empty generators Test Improvements: - Rename misleading testError() to testZeroLimitReturnsEmptyResult() - Add specific exception message assertions for better test precision - Verify expected fetched data values instead of just counts Documentation & Safety: - Update UPGRADE.md to clarify removed types (interface vs class) - Add consumption warning to OffsetResult::generator() method - Use array_key_exists for more precise parameter handling All tests pass (96/96, 488 assertions) and quality checks clean. * perf: make CI coverage configurable for optimal performance - Add optional coverage input to composer-install action (default: none) - Enable xdebug only for tests job, disable for quality job - Reduces CI overhead by avoiding unnecessary coverage instrumentation - Maintains coverage generation where needed while optimizing performance Addresses CodeRabbit suggestion for configurable coverage. * fix: address final CodeRabbit suggestions for code quality - README: Convert bold text to proper heading to avoid markdownlint MD036 - Tests: Parameter names already prefixed with underscores (previously fixed) - Quality: All static analysis and linting checks pass cleanly Completes the comprehensive CodeRabbit review response. * Apply fixes from StyleCI (#10) Co-authored-by: Igor Pinchuk <somework@users.noreply.github.com> * fix: address final CodeRabbit suggestions - CI: Remove redundant continue-on-error: false (default behavior) - UPGRADE.md: Add note about generator consumption semantics for migration clarity All automated code review suggestions now fully addressed. * 📝 Add docstrings to `codex/analyze-pagination-behavior-and-test-design` (#11) * 📝 Add docstrings to `codex/analyze-pagination-behavior-and-test-design` Docstrings generation was requested by @somework. * #7 (comment) The following files were modified: * `src/Exception/InvalidPaginationArgumentException.php` * `src/Exception/InvalidPaginationResultException.php` * `src/OffsetAdapter.php` * `src/OffsetResult.php` * `src/SourceCallbackAdapter.php` * `tests/ArraySource.php` * Apply fixes from StyleCI (#12) Co-authored-by: Igor Pinchuk <somework@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Igor Pinchuk <i.pinchuk.work@gmail.com> Co-authored-by: Igor Pinchuk <somework@users.noreply.github.com> * test: add comprehensive tests for OffsetAdapter::fromCallback method - Add testFromCallbackCreatesAdapterWithCallbackSource() to verify fromCallback works - Add testFromCallbackWithEmptyData() for edge case testing - Tests cover pagination behavior and callback invocation - Improves method coverage from 55.56% to higher percentage Resolves coverage gap for the fromCallback static factory method. * test: improve OffsetAdapter test coverage - Add comprehensive fromCallback method tests - Add edge case tests for empty generators - Add comprehensive method execution test - Improve method coverage from 66.67% to 77.78% (7/9 methods) - Improve line coverage from 92.86% to 95.24% (40/42 lines) Remaining 2 uncovered lines are in AlreadyGetNeededCountException catch block, which is a pagination optimization exception that may be difficult to trigger reliably. * test: achieve near-perfect OffsetAdapter coverage - Improve method coverage from 77.78% to 88.89% (8/9 methods) - Improve line coverage from 95.24% to 97.62% (41/42 lines) - Add testLimitReachedInGeneratorProcessing() to cover break condition in createLimitedGenerator - Add testPaginationWithExtremeParameters() for edge case handling - Successfully covered limit enforcement logic (line 204) Remaining 1 uncovered line (line 138) is safety check for invalid pagination parameters, which is an edge case unlikely to occur in normal operation with the pagination library. * test: add coverage for PaginationException base class - Add testPaginationExceptionBaseClass() to verify inheritance and interface implementation - PaginationException is an empty base class, so 0% coverage is expected (no executable lines) - Confirms proper inheritance: RuntimeException -> PaginationException -> PaginationExceptionInterface Functional classes maintain excellent coverage: - OffsetAdapter: 88.89% methods, 97.62% lines - OffsetResult: 100% methods, 100% lines - SourceCallbackAdapter: 100% methods, 100% lines - Exception classes: 100% coverage each * feat: complete package transformation to production-ready solution Transformed offset-page from functional library to Packagist-ready, DX-first solution: - Enhanced API with fromCallback() and fetchAll() convenience methods - Enterprise exception architecture with comprehensive error handling - Complete documentation overhaul (README, CONTRIBUTING, UPGRADE) - Packagist optimization with SEO keywords and metadata - 99.07% line coverage, 104 tests, enterprise-grade quality - Removed unused PaginationException dead code 29 files changed, 1831 additions, 1356 deletions 104 tests passing, 509 assertions Ready for production release! * Apply fixes from StyleCI (#13) Co-authored-by: Igor Pinchuk <somework@users.noreply.github.com> --------- Co-authored-by: Igor Pinchuk <somework@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request applies code style fixes from an analysis carried out by StyleCI.
For more information, click here.