Skip to content

Add python3 support#14

Open
gargi wants to merge 1 commit intosolvebio:masterfrom
gargi:py3-support
Open

Add python3 support#14
gargi wants to merge 1 commit intosolvebio:masterfrom
gargi:py3-support

Conversation

@gargi
Copy link

@gargi gargi commented Oct 10, 2016

This PR addresses issue #11

@davecap
Copy link
Contributor

davecap commented Oct 10, 2016

Thanks! we will review your PR as soon as possible.

@gargi
Copy link
Author

gargi commented Oct 10, 2016

yes! Please let me know if you have any feedback!

@davecap
Copy link
Contributor

davecap commented Oct 16, 2016

It looks like there might be a few things that broke with the switch to next() instead of obj.next(). See the tests:

It may be possible to fix this by adding the following function to the FileReader class:

def __next__(self):
        return self.next()

Although I'm not sure if that will fix the problem. Are you able to get the tests to run locally in Python 2.7 and Python 3.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants