Skip to content

Conversation

@BillKeenan
Copy link

No description provided.

<string>1.0</string>
<key>MinimumOSVersion</key>
<string>8.0</string>
<string>14.4</string>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for my comment but why u change MinimumOSVersion to 14.4?
we need to support old ios versions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah, I shouldn't have checked that in, I'll update.

@codecov-commenter
Copy link

Codecov Report

Merging #18 (037ba4c) into master (a53d83d) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   98.42%   98.38%   -0.04%     
==========================================
  Files           3        3              
  Lines         127      124       -3     
==========================================
- Hits          125      122       -3     
  Misses          2        2              
Impacted Files Coverage Δ
lib/date_helper.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a53d83d...037ba4c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants