Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion backend-api/__tests__/readinessWarning.test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { buildReadinessWarningDetail } = require("../../workers/provisioner/readinessWarning");
const { buildReadinessWarningDetail, buildReadinessWarningMetadata } = require("../../workers/provisioner/readinessWarning");

describe("buildReadinessWarningDetail", () => {
it("formats a runtime-only readiness warning", () => {
Expand Down Expand Up @@ -54,3 +54,27 @@ describe("buildReadinessWarningDetail", () => {
expect(buildReadinessWarningDetail({})).toBe("readiness checks failed");
});
});

describe("buildReadinessWarningMetadata", () => {
it("includes a flattened warning detail alongside the raw readiness payload", () => {
const readiness = {
runtime: {
ok: false,
url: "http://agent.internal:9090/health",
error: "timeout after 5000ms",
},
gateway: { ok: true },
};

expect(buildReadinessWarningMetadata({
agentId: "agent-123",
host: "agent.internal",
readiness,
})).toEqual({
agentId: "agent-123",
host: "agent.internal",
detail: "runtime unavailable at http://agent.internal:9090/health (timeout after 5000ms)",
readiness,
});
});
});
11 changes: 10 additions & 1 deletion workers/provisioner/readinessWarning.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,13 @@ function buildReadinessWarningDetail(readiness) {
return problems.join('; ') || 'readiness checks failed';
}

module.exports = { buildReadinessWarningDetail };
function buildReadinessWarningMetadata({ agentId, host, readiness }) {
return {
agentId,
host,
detail: buildReadinessWarningDetail(readiness),
readiness,
};
}

module.exports = { buildReadinessWarningDetail, buildReadinessWarningMetadata };
4 changes: 2 additions & 2 deletions workers/provisioner/worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const IORedis = require('ioredis');
const { Pool } = require('pg');
const { agentRuntimeUrl } = require('../../agent-runtime/lib/contracts');
const { waitForAgentReadiness } = require('./healthChecks');
const { buildReadinessWarningDetail } = require('./readinessWarning');
const { buildReadinessWarningDetail, buildReadinessWarningMetadata } = require('./readinessWarning');

// ── Connections ──────────────────────────────────────────
const connection = new IORedis({
Expand Down Expand Up @@ -390,7 +390,7 @@ const worker = new Worker('deployments', async (job) => {
await db.query("UPDATE deployments SET status = 'warning' WHERE agent_id = $1", [id]);
await db.query(
"INSERT INTO events(type, message, metadata) VALUES($1, $2, $3)",
['agent_runtime_warning', `Agent "${name}" deployed with readiness warning: ${detail}`, JSON.stringify({ agentId: id, host, readiness })]
['agent_runtime_warning', `Agent "${name}" deployed with readiness warning: ${detail}`, JSON.stringify(buildReadinessWarningMetadata({ agentId: id, host, readiness }))]
);
}

Expand Down
Loading