feat(helm): enhance secret handling, gateway API support, and database dependencies#2
Closed
KarolayneAmabile wants to merge 9 commits intodevelopfrom
Closed
feat(helm): enhance secret handling, gateway API support, and database dependencies#2KarolayneAmabile wants to merge 9 commits intodevelopfrom
KarolayneAmabile wants to merge 9 commits intodevelopfrom
Conversation
…s, refactor values and templates for improved configuration
KarolayneAmabile
force-pushed
the
feat/gatewayapi-storageclass
branch
5 times, most recently
from
169f30b to
497230a
Compare
Joao-1
requested changes
Aug 4, 2025
| env: | ||
| - name: UPTIME_APP_API_BASE_URL | ||
| value: "{{ .Values.server.protocol }}://{{ .Values.server.ingress.host }}/api/v1" | ||
| value: "{{ .Values.checkmate.server.protocol }}://{{ .Values.checkmate.server.hostname }}/api/v1" |
Member
There was a problem hiding this comment.
I think we can change this to use only the service name and the Checkmate-deployed namespace.
| @@ -7,7 +7,7 @@ metadata: | |||
| nginx.ingress.kubernetes.io/rewrite-target: / | |||
Comment on lines
22
to
28
| resources: | ||
| requests: | ||
| cpu: "100m" | ||
| memory: "128Mi" | ||
| limits: | ||
| cpu: "500m" | ||
| memory: "512Mi" |
| @@ -12,7 +12,7 @@ metadata: | |||
| nginx.ingress.kubernetes.io/cors-allow-credentials: "true" | |||
Allow server deployment to accept secrets via both direct values and existing Kubernetes Secret references. Enhance _prechecks.yaml to validate gatewayAPI and namespace requirements for both client and server. Improve overall Helm chart flexibility and error messaging.
…o feat/gatewayapi-storageclass
KarolayneAmabile
force-pushed
the
feat/gatewayapi-storageclass
branch
from
497230a to
6791043
Compare
Joao-1
force-pushed
the
feat/gatewayapi-storageclass
branch
from
3b200d3 to
18c009c
Compare
Joao-1
force-pushed
the
feat/gatewayapi-storageclass
branch
from
18c009c to
9fe9c09
Compare
KarolayneAmabile
force-pushed
the
feat/gatewayapi-storageclass
branch
10 times, most recently
from
a3b84f6 to
5fd723e
Compare
Joao-1
force-pushed
the
feat/gatewayapi-storageclass
branch
3 times, most recently
from
8d67d86 to
d27a966
Compare
Joao-1
force-pushed
the
feat/gatewayapi-storageclass
branch
from
d27a966 to
b7b700e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.Valuesand existing Kubernetes Secret references..mongodbandredisas chart dependencies usingdependenciesinChart.yaml. These services are now properly managed as optional subcharts via.Values.mongodb.enabledand.Values.redis.enabled.