Skip to content

enable JFR metrics by default #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cleverchuk merged 1 commit into from
Dec 20, 2025
Merged

enable JFR metrics by default #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...m/src/main/java/com/solarwinds/opentelemetry/extensions/SolarwindsPropertiesSupplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,12 @@ public class SolarwindsPropertiesSupplier implements Supplier<Map<String, String
PROPERTIES.put("otel.java.experimental.span-stacktrace.filter", SPAN_STACKTRACE_FILTER_CLASS);
PROPERTIES.put("otel.propagators", String.format("tracecontext,baggage,%s", COMPONENT_NAME));
PROPERTIES.put("otel.semconv-stability.opt-in", "database/dup");

PROPERTIES.put("otel.exporter.otlp.metrics.temporality.preference", "delta");
PROPERTIES.put(
"otel.exporter.otlp.metrics.default.histogram.aggregation",
"base2_exponential_bucket_histogram");
PROPERTIES.put("otel.instrumentation.runtime-telemetry-java17.enable-all", "true");
} else {
PROPERTIES.put("otel.sdk.disabled", "true");
}
Expand Down
7 changes: 7 additions & 0 deletions smoke-tests/k6/basic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,13 @@ export default function () {
)
})

silence(function () {
verify_that_metrics_are_reported("jvm.network.time",
(measurement) => check(measurement, {"otel-metrics-17": mrs => mrs.value > 0}),
service
)
})

silence(function () {
verify_that_metrics_are_reported("trace.jvm.Runtime.Uptime",
(measurement) => check(measurement, {"trace.jvm-metrics": mrs => mrs.value === 0}),
Expand Down
2 changes: 2 additions & 0 deletions smoke-tests/sdk-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ logger_provider:

instrumentation/development:
java:
runtime-telemetry-java17:
enable-all: true
common:
default-enabled: true
solarwinds:
Expand Down
9 changes: 9 additions & 0 deletions smoke-tests/src/test/java/com/solarwinds/SmokeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,15 @@ void assertThatMetricsAreExported() throws IOException {
assertTrue(passes > 0, "otel metric export is broken");
}

@Test
void assertThatRuntimeMetrics17AreExported() throws IOException {
String resultJson = new String(
Files.readAllBytes(namingConventions.local.k6Results(Configs.E2E.config.agents().get(0))));
double passes = ResultsCollector.read(resultJson,
"$.root_group.checks.['otel-metrics-17'].passes");
assertTrue(passes > 0, "JVM 17+ runtime metric export is broken");
}

@Test
void assertThatSdkTracingIsWorking() throws IOException {
String resultJson = new String(
Expand Down
9 changes: 9 additions & 0 deletions smoke-tests/src/test/java/com/solarwinds/SmokeTestV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,15 @@ void assertThatMetricsAreExported() throws IOException {
assertTrue(passes > 0, "otel metric export is broken");
}

@Test
void assertThatRuntimeMetrics17AreExported() throws IOException {
String resultJson = new String(
Files.readAllBytes(namingConventions.local.k6Results(Configs.E2E.config.agents().get(0))));
double passes = ResultsCollector.read(resultJson,
"$.root_group.checks.['otel-metrics-17'].passes");
assertTrue(passes > 0, "JVM 17+ runtime metric export is broken");
}

@Test
void assertThatSdkTracingIsWorking() throws IOException {
String resultJson = new String(
Expand Down
Loading