perf: Migrate to new crypto libraries using dalek's math#402
Open
sparx7783 wants to merge 3 commits intosolana-foundation:mainfrom
Open
perf: Migrate to new crypto libraries using dalek's math#402sparx7783 wants to merge 3 commits intosolana-foundation:mainfrom
sparx7783 wants to merge 3 commits intosolana-foundation:mainfrom
Conversation
Contributor
sonicfromnewyoke
left a comment
There was a problem hiding this comment.
awesome MR, thanks 🙏
Co-authored-by: Sonic <sonic.from.new.yoke@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Go's std lib
crypto/ed25519is not using the optimized ed25519 math used in Dalek's rust lib, which offers significant performance improvements, we can switch togithub.com/oasisprotocol/curve25519-voito get these improvements.Summary of Changes
Migrate from
crypto/ed25519andfilippo.io/edwards25519to newoasisprotocol/curve25519-voi, with slightly rewriting the isOnCurve verification function for slight api differences. UsesVerifyWithOptions(..., verifyOptionsStdLib)to keep verification 1:1 with the previous stdlib implementation.Benchmarks
main(stdlib + filippo)voiSignVerifyIsOnCurveFindAssociatedTokenAddress(wSOL)