feat: is token mint classifier#401
Open
sonicfromnewyoke wants to merge 1 commit intosolana-foundation:mainfrom
Open
feat: is token mint classifier#401sonicfromnewyoke wants to merge 1 commit intosolana-foundation:mainfrom
sonicfromnewyoke wants to merge 1 commit intosolana-foundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
classifying accs as Mints on the hot path of an indexer or unfiltered getProgramAccounts pipeline is expensive if done via a full borsh decode - hundreds of nanoseconds and dozens of allocations per candidate, most of which are discarded.
#396 proposes a byte-level
IsTokenMint(acc *Account) boolhelper, but the submitted version has a latent nil-panic onacc == nil, uses magic numbers, and orders its checks so every call pays for a 32-byte PublicKey comparison - including the majority case where the account isn't a token at allSummary of Changes
Benches
supresses #396