fix: reject malformed ed25519 private keys in PrivateKeyFromBase58#399
Open
tanmay4l wants to merge 2 commits intosolana-foundation:mainfrom
Open
fix: reject malformed ed25519 private keys in PrivateKeyFromBase58#399tanmay4l wants to merge 2 commits intosolana-foundation:mainfrom
tanmay4l wants to merge 2 commits intosolana-foundation:mainfrom
Conversation
Contributor
sonicfromnewyoke
left a comment
sonicfromnewyoke
left a comment
There was a problem hiding this comment.
i really like it, thank you 🙏
old validation was essentially decorative - it rejected the narrow case of corrupted public keys that also happened to be off-curve, but silently accepted the much larger class of inconsistent keys
so, i believe this MR is a real step towards more secure apps
tanmay4l
force-pushed
the
main
branch
4 times, most recently
from
e4e3304 to
c7cb94e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.