fix: memo program parity#395
Merged
HealthyBuilder merged 1 commit intosolana-foundation:mainfrom Apr 16, 2026
Merged
Conversation
Collaborator
|
Great parity work with fuzz tests. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
memo program SDK was incomplete compared to the original Solana memo program
it only supported a single signer (the original supports 0..N), didn't allow unsigned memos, had no client-side UTF-8 validation, was missing the v1 program ID for legacy transaction decoding, and had hardcoded program address strings in tests
there were also no tests for the package at all
Summary of Changes
NewMemoInstruction(message, signers...)and newAddSigner()methodMemo1UhkJRfHyvLMcVucJwxXeuD728EqVDDwQDxFMNoto program_idstest_utf8_memoandtest_signersfrom the original Rust implementation