Optimize IsOnCurve and upgrade edwards25519#390
Merged
HealthyBuilder merged 2 commits intosolana-foundation:mainfrom Apr 16, 2026
Merged
Optimize IsOnCurve and upgrade edwards25519#390HealthyBuilder merged 2 commits intosolana-foundation:mainfrom
HealthyBuilder merged 2 commits intosolana-foundation:mainfrom
Conversation
Collaborator
|
Nice optimization + CVE fix. Merging. Thanks @gojuukaze! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Optimize IsOnCurve implementation
The original implementation relied on:
to determine whether a public key lies on the Ed25519 curve. However,
SetBytesperforms additional computations after derivingwasSquare, which are unnecessary for this validation use case.This PR inlines the relevant logic from
SetBytesand removes the redundant steps, resulting in a more efficientIsOnCurvecheck without changing its behavior.2. Upgrade filippo.io/edwards25519 to v1.2.0
Upgraded from v1.1.0 to v1.2.0 to address a known vulnerability: CVE-2026-26958
Although this issue does not directly impact
solana-go, upgrading ensures better security hygiene and avoids potential future risks.