feat: vote program complete#387
Open
sonicfromnewyoke wants to merge 1 commit intosolana-foundation:mainfrom
Open
feat: vote program complete#387sonicfromnewyoke wants to merge 1 commit intosolana-foundation:mainfrom
sonicfromnewyoke wants to merge 1 commit intosolana-foundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vote program implementation covered only a small subset of ixns, and three of those were stubs with TODO comments and no data fields - they would silently produce wrong bytes if used.
on-chain state types were entirely missing, so vote accounts returned from RPC couldn't be decoded.
also, there were no tests, this made the vote package effectively unusable for reading account state or submitting anything beyond a basic withdraw.
Summary of Changes