Skip to content

fix: detect v0 tx version from AddressTableLookups in JSON#377

Open
vukamecos wants to merge 1 commit intosolana-foundation:mainfrom
vukamecos:fix/issue-339-message-version
Open

fix: detect v0 tx version from AddressTableLookups in JSON#377
vukamecos wants to merge 1 commit intosolana-foundation:mainfrom
vukamecos:fix/issue-339-message-version

Conversation

@vukamecos
Copy link
Copy Markdown

Fixes #339

@vukamecos vukamecos force-pushed the fix/issue-339-message-version branch from cdb62b0 to 6997be0 Compare April 4, 2026 23:48
@sonicfromnewyoke
Copy link
Copy Markdown
Contributor

@vukamecos thank you for the contribution

v0 transactions without lookups are still misclassified.

a v0 transaction can have an empty addressTableLookups array
the versioned format is independent of whether lookups are actually used
this heuristic only covers the most common case but silently misclassifies v0-no-lookups transactions as legacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marshalling Transaction from RPC response with EncodingJSON sets incorrect versioning

2 participants