Skip to content

fix: lookup tables ordering#365

Merged
HealthyBuilder merged 1 commit intosolana-foundation:mainfrom
sonicfromnewyoke:sonic/fix-alut
Apr 2, 2026
Merged

fix: lookup tables ordering#365
HealthyBuilder merged 1 commit intosolana-foundation:mainfrom
sonicfromnewyoke:sonic/fix-alut

Conversation

@sonicfromnewyoke
Copy link
Copy Markdown
Contributor

Problem

neither #364 nor #344 completely fix the issue with non-deterministic v0 message with multiple address lookup tables

Summary of Changes

  • sort map keys before iterating in NewTransaction
  • fix serialization format
  • use tests from the original solana-sdk to verify correctness of work

should suppress #344 #364

cc @daog1

@HealthyBuilder HealthyBuilder merged commit 1ba0d4b into solana-foundation:main Apr 2, 2026
12 checks passed
@HealthyBuilder
Copy link
Copy Markdown
Collaborator

Hey @sonicfromnewyoke, CI on main is red after merging both #296 and #365.
The root cause: #296 added a PublicKey tiebreaker to AccountMeta.less(), which changes the deterministic ordering of Message.AccountKeys. The hardcoded expected values in transaction_test.go now need to be updated to match:

TestNewTransaction (lines 87-97)
TestTransactionSerializePumpFunSwap (line 364)

Can you submit a quick fix PR to update these expected values? Just run the tests locally, grab the new deterministic output, and update the assertions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants