fix: lookup tables ordering#365
Merged
HealthyBuilder merged 1 commit intosolana-foundation:mainfrom Apr 2, 2026
Merged
Conversation
Collaborator
|
Hey @sonicfromnewyoke, CI on main is red after merging both #296 and #365. TestNewTransaction (lines 87-97) Can you submit a quick fix PR to update these expected values? Just run the tests locally, grab the new deterministic output, and update the assertions. Thanks! |
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
neither #364 nor #344 completely fix the issue with non-deterministic v0 message with multiple address lookup tables
Summary of Changes
NewTransactionsolana-sdkto verify correctness of workshould suppress #344 #364
cc @daog1