Enhance the HTTP error and JSON-RPC error handle#342
Open
0xcary wants to merge 10 commits intosolana-foundation:mainfrom
Open
Enhance the HTTP error and JSON-RPC error handle#3420xcary wants to merge 10 commits intosolana-foundation:mainfrom
0xcary wants to merge 10 commits intosolana-foundation:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the HTTP error handling and header management in the JSON-RPC client codebase. The main improvements include a more informative
HTTPErrortype, proper propagation of HTTP status and body in error cases, and enhanced support for custom headers via context. Additionally, new tests have been added to verify header manipulation functionality.Error handling improvements:
HTTPErrortype to includeStatusCode,Status, and responseBody, and updated its error message formatting for better debugging. [1] [2]doCall,doCallWithCallbackOnHTTPResponse, anddoBatchCallto return the newHTTPErrorwith status and body, and simplified error propagation. [1] [2] [3] [4]Header management enhancements:
context_headers.gowith utilities to inject and extract HTTP headers from acontext.Context, allowing per-request header customization.Testing improvements:
client_test.goto verify setting, modifying, removing, and retrieving headers, as well as checking that headers are correctly sent in requests.API usage safeguards:
NewClientWithOptsif the endpoint is empty, enforcing correct usage.