Open
Conversation
This avoids nested loops over all accounts.
This seems to show up as runtime.duffcopy in my profiles.
palmerlao
changed the title
Author
|
@gagliardetto I can't seem to add you as a reviewer to this PR. Would you mind taking a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AccountMetaList calls IsWritable and IsSigner in a loop over GetAllKeys. IsWritable and IsSigner both have a loop over GetAllKeys too. I refactored logic from IsWritable and IsSigner using the account index and call that instead, since both of those functions already must have resolved the message's accounts.
I also changed the Message method receiver to a pointer to reduce copies of that struct, which I believe appear in the profile as duffcopy.
I reduced calls to numStaticAccounts (which evaluate NumLookups) and removed the MessageAddressTableLookup struct copies because I think those also contributed to the duffcopy node.
before:
after:
