-
Notifications
You must be signed in to change notification settings - Fork 225
release: 2.0.2 #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 2.0.2 #299
Conversation
- Hotfix for get fee for message for v0 transactions with lookup tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 638f3b4 in 1 minute and 32 seconds. Click for details.
- Reviewed
92lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Cargo.toml:1
- Draft comment:
Workspace Cargo.toml bump and dependency versions look consistent. Note the use of Hyper 1.5.1 – double-check that this version is intentional, as most projects use Hyper 0.14.x. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
2. Cargo.toml:22
- Draft comment:
Workspace dependencies are pinned; versions such as tracing "0.1" and others appear deliberate—just verify they meet your compatibility requirements. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. crates/cli/Cargo.toml:1
- Draft comment:
CLI Cargo.toml correctly uses workspace dependencies; the package version matches the bump to 2.0.2 and README path is valid. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. crates/lib/Cargo.toml:96
- Draft comment:
In dev-dependencies, 'tokio' is separately specified as 1.0 with specific features. Consider aligning it with the workspace tokio version (1.41.1) to avoid version conflicts or duplicate copies. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. crates/lib/Cargo.toml:92
- Draft comment:
The 'unsafe-debug' feature is flagged with a warning—make sure its documentation clearly instructs users not to enable it in production. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_46ohbYHjZfpTkkmz
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Greptile OverviewGreptile SummaryThis PR performs a version bump to release 2.0.2, which includes a hotfix for v0 transactions with address lookup tables that was previously merged in PR #297. ContextThe actual bug fix was implemented in the previous commit (36970d8, PR #297), which removed a workaround that was converting v0 messages to legacy messages when calling What Changed in This PRThis release PR updates version numbers across all workspace packages from 2.0.1 to 2.0.2:
Version ConsistencyAll version references have been properly synchronized:
The hotfix addresses a critical issue where large v0 transactions using address lookup tables would fail with "transaction too big" errors when the system attempted to manually serialize them by converting to legacy format. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant PR297 as PR #297 (Hotfix)
participant Code as crates/lib/src/fee/fee.rs
participant PR299 as PR #299 (Release)
participant Cargo as Cargo Files
participant CL as CHANGELOG.md
Note over Dev,CL: Phase 1: Hotfix Implementation
Dev->>PR297: Implement fix for v0 transactions
PR297->>Code: Remove workaround converting v0 to legacy
Code->>Code: Now uses v0_message directly in get_fee_for_message
Note over Code: Fix: Prevents "transaction too big" error<br/>for v0 transactions with lookup tables
Note over Dev,CL: Phase 2: Release Version Bump (This PR)
Dev->>PR299: Create release PR for v2.0.2
PR299->>Cargo: Update workspace version 2.0.1 → 2.0.2
PR299->>Cargo: Update kora-lib version 2.0.1 → 2.0.2
PR299->>Cargo: Update kora-cli version 2.0.1 → 2.0.2
PR299->>Cargo: Update kora-cli dependency on kora-lib
PR299->>Cargo: Update Cargo.lock for all packages
PR299->>CL: Add 2.0.2 changelog entry
CL->>CL: Document hotfix (PRO-639) referencing PR #297
Note over Dev,CL: After Merge
Dev->>Dev: Publish to crates.io via GitHub Actions
Dev->>Dev: Create git tags (v2.0.2, kora-lib-v2.0.2, kora-cli-v2.0.2)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: README.md
Line: 22:22
Comment:
The README.md still references v2.0.1 as the latest stable release, but this should be updated to v2.0.2 since this is a new release. The link should point to the new release tag.
```suggestion
> **Branch Update (Jan 6, 2025):** We migrated pre-release features to [`release/2.2.0`](https://github.com/solana-foundation/kora/tree/release/2.2.0). The `main` branch now only contains audited releases plus minor hotfixes/docs. See [v2.0.2](https://github.com/solana-foundation/kora/releases/tag/v2.0.2) for the latest stable release.
```
How can I resolve this? If you propose a fix, please make it concise. |
Important
Hotfix release 2.0.2 fixes error with big transactions using v0 transaction and lookup tables, with version updates across Cargo files.
2.0.2inCargo.toml,crates/cli/Cargo.toml, andcrates/lib/Cargo.toml.Cargo.lockto reflect new version2.0.2.2.0.2inCHANGELOG.mddetailing the hotfix.This description was created by
for 638f3b4. You can customize this summary. It will automatically update as commits are pushed.
📊 Unit Test Coverage
Unit Test Coverage: 80.7%
View Detailed Coverage Report