Skip to content

Conversation

@dev-jodee
Copy link
Contributor

@dev-jodee dev-jodee commented Jan 12, 2026

  • Hotfix for get fee for message for v0 transactions with lookup tables

Important

Hotfix release 2.0.2 fixes error with big transactions using v0 transaction and lookup tables, with version updates across Cargo files.

  • Hotfix:
    • Fixes error with big transactions using v0 transaction and lookup tables.
  • Version Updates:
    • Bumps version to 2.0.2 in Cargo.toml, crates/cli/Cargo.toml, and crates/lib/Cargo.toml.
    • Updates Cargo.lock to reflect new version 2.0.2.
  • Documentation:
    • Adds entry for version 2.0.2 in CHANGELOG.md detailing the hotfix.

This description was created by Ellipsis for 638f3b4. You can customize this summary. It will automatically update as commits are pushed.

📊 Unit Test Coverage

Coverage

Unit Test Coverage: 80.7%

View Detailed Coverage Report

- Hotfix for get fee for message for v0 transactions with lookup tables
@dev-jodee dev-jodee requested a review from amilz January 12, 2026 17:08
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 638f3b4 in 1 minute and 32 seconds. Click for details.
  • Reviewed 92 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Cargo.toml:1
  • Draft comment:
    Workspace Cargo.toml bump and dependency versions look consistent. Note the use of Hyper 1.5.1 – double-check that this version is intentional, as most projects use Hyper 0.14.x.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
2. Cargo.toml:22
  • Draft comment:
    Workspace dependencies are pinned; versions such as tracing "0.1" and others appear deliberate—just verify they meet your compatibility requirements.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
3. crates/cli/Cargo.toml:1
  • Draft comment:
    CLI Cargo.toml correctly uses workspace dependencies; the package version matches the bump to 2.0.2 and README path is valid.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. crates/lib/Cargo.toml:96
  • Draft comment:
    In dev-dependencies, 'tokio' is separately specified as 1.0 with specific features. Consider aligning it with the workspace tokio version (1.41.1) to avoid version conflicts or duplicate copies.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. crates/lib/Cargo.toml:92
  • Draft comment:
    The 'unsafe-debug' feature is flagged with a warning—make sure its documentation clearly instructs users not to enable it in production.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_46ohbYHjZfpTkkmz

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@greptile-apps
Copy link

greptile-apps bot commented Jan 12, 2026

Greptile Overview

Greptile Summary

This PR performs a version bump to release 2.0.2, which includes a hotfix for v0 transactions with address lookup tables that was previously merged in PR #297.

Context

The actual bug fix was implemented in the previous commit (36970d8, PR #297), which removed a workaround that was converting v0 messages to legacy messages when calling get_fee_for_message. The workaround was originally added to handle an agave validator serialization issue (referenced in anza-xyz/agave#7719). Since that upstream issue has been resolved, the workaround was removed, allowing v0 transactions to be processed directly without conversion.

What Changed in This PR

This release PR updates version numbers across all workspace packages from 2.0.1 to 2.0.2:

  • Root workspace version in Cargo.toml
  • kora-cli package version and its dependency on kora-lib
  • kora-lib package version
  • Lock file updates for all three packages (kora-cli, kora-lib, tests)
  • CHANGELOG.md entry documenting the hotfix

Version Consistency

All version references have been properly synchronized:

  • ✅ Workspace version: 2.0.2
  • ✅ kora-lib version: 2.0.2
  • ✅ kora-cli version: 2.0.2
  • ✅ kora-cli dependency on kora-lib: 2.0.2
  • ✅ Cargo.lock updated correctly
  • ✅ tests package inherits workspace version
  • ⚠️ README.md still references v2.0.1 (see comment)

The hotfix addresses a critical issue where large v0 transactions using address lookup tables would fail with "transaction too big" errors when the system attempted to manually serialize them by converting to legacy format.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it's a straightforward version bump for a hotfix release
  • This is a standard release PR with proper version synchronization across all workspace packages. The actual bug fix was already merged in PR hotfix: (PRO-639) Fix big transaction causing error when using v0 tra… #297, and this PR only updates version numbers and documentation. All version references are consistent (2.0.2 across workspace, kora-lib, kora-cli, and Cargo.lock). The CHANGELOG entry properly documents the hotfix. The only minor issue is that README.md references the old v2.0.1 release, but this doesn't affect the build or functionality.
  • No files require special attention - all changes are straightforward version updates

Important Files Changed

File Analysis

Filename Score Overview
CHANGELOG.md 5/5 Adds changelog entry for version 2.0.2 hotfix release with proper formatting and reference to PR #297
Cargo.toml 5/5 Updates workspace version from 2.0.1 to 2.0.2, properly synchronized across workspace
crates/cli/Cargo.toml 5/5 Updates kora-cli version to 2.0.2 and updates kora-lib dependency version to match
crates/lib/Cargo.toml 5/5 Updates kora-lib version to 2.0.2, consistent with workspace version
Cargo.lock 5/5 Updates lock file to reflect version 2.0.2 for kora-cli, kora-lib, and tests packages

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant PR297 as PR #297 (Hotfix)
    participant Code as crates/lib/src/fee/fee.rs
    participant PR299 as PR #299 (Release)
    participant Cargo as Cargo Files
    participant CL as CHANGELOG.md

    Note over Dev,CL: Phase 1: Hotfix Implementation
    Dev->>PR297: Implement fix for v0 transactions
    PR297->>Code: Remove workaround converting v0 to legacy
    Code->>Code: Now uses v0_message directly in get_fee_for_message
    Note over Code: Fix: Prevents "transaction too big" error<br/>for v0 transactions with lookup tables

    Note over Dev,CL: Phase 2: Release Version Bump (This PR)
    Dev->>PR299: Create release PR for v2.0.2
    PR299->>Cargo: Update workspace version 2.0.1 → 2.0.2
    PR299->>Cargo: Update kora-lib version 2.0.1 → 2.0.2
    PR299->>Cargo: Update kora-cli version 2.0.1 → 2.0.2
    PR299->>Cargo: Update kora-cli dependency on kora-lib
    PR299->>Cargo: Update Cargo.lock for all packages
    PR299->>CL: Add 2.0.2 changelog entry
    CL->>CL: Document hotfix (PRO-639) referencing PR #297

    Note over Dev,CL: After Merge
    Dev->>Dev: Publish to crates.io via GitHub Actions
    Dev->>Dev: Create git tags (v2.0.2, kora-lib-v2.0.2, kora-cli-v2.0.2)
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Jan 12, 2026

Additional Comments (1)

README.md
The README.md still references v2.0.1 as the latest stable release, but this should be updated to v2.0.2 since this is a new release. The link should point to the new release tag.

> **Branch Update (Jan 6, 2025):** We migrated pre-release features to [`release/2.2.0`](https://github.com/solana-foundation/kora/tree/release/2.2.0). The `main` branch now only contains audited releases plus minor hotfixes/docs. See [v2.0.2](https://github.com/solana-foundation/kora/releases/tag/v2.0.2) for the latest stable release.
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 22:22

Comment:
The README.md still references v2.0.1 as the latest stable release, but this should be updated to v2.0.2 since this is a new release. The link should point to the new release tag.

```suggestion
> **Branch Update (Jan 6, 2025):** We migrated pre-release features to [`release/2.2.0`](https://github.com/solana-foundation/kora/tree/release/2.2.0). The `main` branch now only contains audited releases plus minor hotfixes/docs. See [v2.0.2](https://github.com/solana-foundation/kora/releases/tag/v2.0.2) for the latest stable release.
```

How can I resolve this? If you propose a fix, please make it concise.

@dev-jodee dev-jodee merged commit 8958f29 into main Jan 12, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants