MPT-8695 add support for clickhouse ssl connection #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturbalabanov
approved these changes
Apr 7, 2025
arturbalabanov
left a comment
arturbalabanov
left a comment
There was a problem hiding this comment.
added two super minor comments, nothing blocking, feel free to resolve as you see fit
changes look good otherwise :)
| """ | ||
| Get tuple with access args for clickhouse db | ||
| :return: ('username', 'password', 'host ip', 'db name') | ||
| """ |
There was a problem hiding this comment.
nitpick: can you please add the new parameter to the docstring?
| params = self.read_branch('/clickhouse') | ||
| return (params['user'], params['password'], params['host'], | ||
| params['db']) | ||
| params['db'], params.get('secure', False) == "True") |
There was a problem hiding this comment.
Another nitpick -- worth making the string comparison case-insensitive or allow for boolean True to also be accepted to avoid potential headaches when debugging if the parameters are provided manually
ffaraone
force-pushed
the
MPT-8695_support_ssl_for_clickhouse
branch
from
275f191 to
9273260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.