MPT-9247 Sync upstream/2025042801-public -> main 2025-05-02 #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clickhouse-connect instead of clickhouse-driver
## Description How to get a verification code description added.
## Description Added ability to restrict actions by adding role_purpose in context ## Related issue number OSN-802 ## Special notes <!-- Please provide additional information if required. --> ## Checklist * [ ] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
## Description Added optscale roles doc ## Related issue number OSN-814 ## Special notes <!-- Please provide additional information if required. --> ## Checklist * [ ] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
## Description Added doc for external mongo/clickhouse ## Related issue number OSN-752 ## Special notes <!-- Please provide additional information if required. --> ## Checklist * [ ] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
## Description - after successfully downloading the object, we deleted it from the minio. And if sendmail fails we get 404 on retrying task - In case of a large number of retry attempts, when 1 attempt remains, we delete the task, but do not clear the storage. Therefore, such files are stored in minio forever. ## Related issue number OSN-770 ## Special notes <!-- Please provide additional information if required. --> ## Checklist * [ ] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
- Changed the helper message ID in the ReservedInstances component to reflect the correct translation key. - Added a new translation entry for the savings with minimal commitment help message in the app.json file.
## Description Fixed dependabot workflow permissions issue ## Related issue number OSN-820 ## Special notes <!-- Please provide additional information if required. --> ## Checklist * [ ] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
- Introduced the S3DuplicatesBucketsList component to encapsulate bucket name display logic. By default, only the first five buckets are shown, with the remaining buckets hidden behind a "Show more/less" toggle. - Improved DashedTypography styles for better visual consistency. Replaced the border style with an ::after element to prevent layout shifts caused by the border.
ffaraone
force-pushed
the
sync-2025042801-public
branch
from
c2e7d15 to
fdd5bfe
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| headers={"x-api-key": TOKEN1}) | ||
| assert response.status == 400 | ||
| assert "Input should be a valid boolean" in response.text | ||
| assert "Input should be a valid integer" in response.text |
Check notice
Code scanning / Bandit
Use of assert detected. The enclosed code will be removed when compiling to optimised byte code. Note test
| subprocess.check_output( | ||
| [self.exe_path, "destroy", "--auto-approve"], | ||
| cwd=path).decode('UTF-8') | ||
| except Exception: |
Check notice
Code scanning / Bandit
Try, Except, Pass detected. Note
| if out.returncode != 0: | ||
| out = out.stderr.decode("UTF-8") | ||
| raise Exception(out) | ||
| out = out.stdout.decode("UTF-8") |
Check notice
Code scanning / Bandit
subprocess call - check for execution of untrusted input. Note
| f"AND date <= {task.get('end_date')})") | ||
| date_intervals = " OR ".join(date_intervals) | ||
| expenses = self.clickhouse_cl.execute(f""" | ||
| expenses_q = self.clickhouse_cl.query(f""" |
Check warning
Code scanning / Bandit
Possible SQL injection vector through string-based query construction. Warning
ffaraone
force-pushed
the
sync-2025042801-public
branch
from
fdd5bfe to
cd33995
Compare
antoniodimariano
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the latest changes from upstream.