MPT-15021 monitor and restart failed processes #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffaraone
force-pushed
the
MPT-15021_restart_failed_child_processes
branch
from
89ad352 to
1c04f64
Compare
|
arturbalabanov
approved these changes
Oct 31, 2025
| for worker_id, process in self.worker_processes.items(): | ||
| if not process.is_alive(): | ||
| logger.warning(f"Worker {worker_id} [{process.pid}] died unexpectedly") | ||
| process.stop(sigint_timeout=1, sigkill_timeout=1) |
There was a problem hiding this comment.
Perhaps it's better to wrap this in try-except as well the except bellow will stop the iteration?
antoniodimariano
approved these changes
Oct 31, 2025
bdjilka
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.