OAuth #628
Merged
OAuth #628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
however the authentication still will not work
…ger used. Updated documentation
…ode and secure http cookie
hkamm123
reviewed
Jan 22, 2026
Maillman
reviewed
Jan 22, 2026
Contributor
Maillman
left a comment
Maillman
left a comment
There was a problem hiding this comment.
Great work! I was able to run the autograder locally, and everything is working as it should! There are a couple of minor things I've noticed, and some suggestions for some parts of the code. But overall, this looks great!
Thanks, Makenna!!!
src/test/java/edu/byu/cs/service/AuthenticationServiceTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thank you for the feedback @Maillman! Glad you were able to get it going. Do you have any complaints about the process of getting running on your machine? |
Contributor
|
@mewilker I don't have any personal complaints about getting it set up. The process felt pretty smooth for me! |
TheDavSmasher
approved these changes
Jan 27, 2026
Collaborator
TheDavSmasher
left a comment
TheDavSmasher
left a comment
There was a problem hiding this comment.
I've already suggested everything I could see and think of so looks good to me
Maillman
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is an overhall of the authentication. Currently, we use CAS protocol to redirect students to the BYU sign-in. This change will use OAuth to authenticate and grab an identity token.
Details
Testing
Future Work
In order to reduce the number of changes to the code, the autograder will still make it's own tokens to call the authenticated endpoints. However, it may be a good idea to refactor and rely completely on the BYU granted tokens.
Additional Notes
Please ensure that you can use the new setup. I made big changes to the code here, and I want to make sure new devs can follow the instructions. Please comment if you feel there are additions to the documentation that would be helpful. I will not go through all the specifics: there is BYU documentation for that.
I have notifications for this change to go live on January 27th. Please try to have your feedback in before then.