Conversation
Collaborator
|
I think the scope diagram will work better if it shows some actual JavaScript with actual variables with the same and different names, and arrows pointing from uses to definitions. |
gvwilson
requested changes
Sep 13, 2019
Collaborator
gvwilson
left a comment
There was a problem hiding this comment.
Commented in GitHub: I think we need to show two variables with the same name to show what overrides what - arrows pointing from names to definitions, etc.
Collaborator
Author
Collaborator
|
I'm liking this, but both |
Collaborator
Author
Contributor
|
Hi @MayaGans I use this as a memory map while working with Javascript. Heavily inspired by Will Sentance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Is a scope figure of interest? I tried to stay on brand but I'm not sure what font you've been using. In this PR I:
Maybe I should add some arrows to show the inside variables can access the global but not the other way around?