fix: correct base64 data URI segment count validation in readImage#809
Closed
ionkorol wants to merge 1 commit intosoftware-mansion:mainfrom
Closed
fix: correct base64 data URI segment count validation in readImage#809ionkorol wants to merge 1 commit intosoftware-mansion:mainfrom
ionkorol wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
Member
|
Thank you @ionkorol for your PR, this totally makes sense. I'll test this change tommorow and probably add some test cases to our test suite :) |
12 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A base64 data URI (e.g. data:image/png;base64,iVBOR...) splits into 2 segments by ,, but the check was comparing against 1, causing all valid base64 image inputs to be rejected.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes