feat: expose map content padding (top, bottom, start, end)#145
Open
arturgesiarz wants to merge 2 commits intomainfrom
Open
feat: expose map content padding (top, bottom, start, end)#145arturgesiarz wants to merge 2 commits intomainfrom
arturgesiarz wants to merge 2 commits intomainfrom
Conversation
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
Comment on lines
+106
to
+112
| val padding = properties.contentPadding ?: MapContentPadding() | ||
| map.setPadding( | ||
| padding.start.toInt(), | ||
| padding.top.toInt(), | ||
| padding.end.toInt(), | ||
| padding.bottom.toInt(), | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| val padding = properties.contentPadding ?: MapContentPadding() | |
| map.setPadding( | |
| padding.start.toInt(), | |
| padding.top.toInt(), | |
| padding.end.toInt(), | |
| padding.bottom.toInt(), | |
| ) | |
| properties.contentPadding?.run { | |
| map.setPadding(start.toInt(), top.toInt(), end.toInt(), bottom.toInt()) | |
| } |
Comment on lines
+126
to
+134
| val contentPadding = properties.contentPadding ?: MapContentPadding() | ||
| view.setLayoutMargins( | ||
| UIEdgeInsetsMake( | ||
| contentPadding.top.toDouble(), | ||
| contentPadding.start.toDouble(), | ||
| contentPadding.bottom.toDouble(), | ||
| contentPadding.end.toDouble(), | ||
| ) | ||
| ) |
Comment on lines
+140
to
+148
| val contentPadding = properties.contentPadding ?: MapContentPadding() | ||
| view.setPadding( | ||
| UIEdgeInsetsMake( | ||
| contentPadding.top.toDouble(), | ||
| contentPadding.start.toDouble(), | ||
| contentPadding.bottom.toDouble(), | ||
| contentPadding.end.toDouble(), | ||
| ) | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add padding
Remove padding from JVM