Skip to content

close #17 needed to refactor to taking button dat to composition #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
softloud merged 1 commit into from
Oct 12, 2025
Merged

close #17 needed to refactor to taking button dat to composition #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion button_2/classes/entities/employee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import random
from classes.data.button_dat import ButtonDat
from ..data.button_dat import ButtonDat

class Employee:
def __init__(self, button_dat: ButtonDat):
Expand Down
10 changes: 2 additions & 8 deletions button_2/tests/entities/test_employee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@
from button_2.classes.data.button_dat import ButtonDat

button_dat = ButtonDat()
employee = Employee(
job_title=button_dat.employee_df.iloc[0]['job_title'] if not button_dat.employee_df.empty else None,
department=button_dat.employee_df.iloc[0]['department'] if not button_dat.employee_df.empty else None
)
employee = Employee(button_dat)

def test_employee_init():
assert employee is not None
Expand Down Expand Up @@ -34,10 +31,7 @@ def helper_test_reorg_method():
# so will run multiple times in main test

initial_state = (employee.job_title, employee.department)
employee.set_current_titles(
job_titles=button_dat.employee_df['job_title'].dropna().values,
departments=button_dat.employee_df['department'].dropna().values
)
employee.set_current_titles()
new_state = (employee.job_title, employee.department)
return {"state_change": initial_state != new_state,
"job_title": employee.job_title,
Expand Down