bump faraday version - to avoid multipart warning#1
Open
BassamAziz wants to merge 7 commits intomasterfrom
Open
bump faraday version - to avoid multipart warning#1BassamAziz wants to merge 7 commits intomasterfrom
BassamAziz wants to merge 7 commits intomasterfrom
Conversation
help_scout-sdk.gemspec
Outdated
|
|
||
| spec.add_dependency 'activesupport' | ||
| spec.add_dependency 'faraday', '1.7.2' | ||
| spec.add_dependency 'faraday', '1.9.0' |
There was a problem hiding this comment.
@mfittko @BassamAziz any reason why we don't update this to 1.9.3?
|
@bassam we could probably go to latest faraday (2.9.0) - let's run the tests though |
mfittko
reviewed
Feb 26, 2024
lib/help_scout/api/client.rb
Outdated
| if authorize? | ||
| HelpScout::API::AccessToken.refresh! | ||
| conn.authorization(:Bearer, access_token) if access_token | ||
| conn.request :authorization, 'Bearer', 'authentication-token' if access_token |
There was a problem hiding this comment.
@mfittko I think this isn't working yet, because when I run a HelpsScout query in the console of the update-bugsnag-faraday branch, I get the error HelpScout::API::NotAuthorized: The access token is invalid or has expired I don't get the error if I try that on master. Also the same error shows up on bugsnag for the testing_cobain_testing stage on bugsnag from last nights cron-jobs - not sure if that is related?
There was a problem hiding this comment.
ouch, yeah we need to use the token not some random string 🤦
mfittko
reviewed
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.