Skip to content

add test line#16

Closed
soehms wants to merge 5 commits intosync_labels_merge_commitfrom
test_sync_labels_merge_commit
Closed

add test line#16
soehms wants to merge 5 commits intosync_labels_merge_commitfrom
test_sync_labels_merge_commit

Conversation

@soehms
Copy link
Owner

@soehms soehms commented Sep 18, 2025

This PR is just for test purpose!

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soehms is there where you wanted me to request changes as a test?

@soehms
Copy link
Owner Author

soehms commented Sep 20, 2025

Testlog merge develop

After I merged develop into this branch, the s: needs_work label remains. Here is the logfile from the run:

INFO:root:cmdline_args (5) ['synchronize', 'https://github.com/soehms/sage/pull/16', 'soehms', '', '']
INFO:root:action: Action.synchronize
INFO:root:url: https://github.com/soehms/sage/pull/16
INFO:root:actor: soehms
INFO:root:label: 
INFO:root:rev_state: 
INFO:root:Create label handler for pull request #16 and actor soehms
INFO:root:version: b'gh version 2.78.0 (2025-08-21)
DEBUG:root:auth status err: b''
DEBUG:root:auth status out: b'github.com\n  \xe2\x9c\x93 Logged in to github.com account github-actions[bot] (GITHUB_TOKEN)\n  - Active account: true\n  - Git operations protocol: https\n  - Token: ghs_************************************\n'
INFO:root:Bot is github-actions
DEBUG:root:Execute command: gh api -X GET -H "Accept: application/vnd.github+json" /repos/soehms/sage/issues/comments -f per_page=100 -f page=1 -f since=2025-09-20T05:47:42Z
INFO:root:Cleaning warning comments since 2025-09-20 05:47:42.546381 (total found 0)
DEBUG:root:Execute command: gh api -X GET -H "Accept: application/vnd.github+json" /repos/soehms/sage/pulls/16/reviews -f per_page=100 -f page=1
DEBUG:root:Execute command: gh pr view https://github.com/soehms/sage/pull/16 --json isDraft
INFO:root:Issue pull request #16 is draft False
DEBUG:root:Execute command: gh pr view https://github.com/soehms/sage/pull/16 --json reviews
DEBUG:root:Reviews for pull request #16: [{'id': 'PRR_kwDOI72C3M7BLZGg', 'author': {'login': 'vincentmacri'}, 'authorAssociation': 'NONE', 'body': '@soehms is there where you wanted me to request changes as a test?', 'submittedAt': '2025-09-18T16:57:25Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED', 'commit': {'oid': '7d330aabaf1073410ea139da2066f7ce493efe08'}}]
DEBUG:root:Execute command: gh pr view https://github.com/soehms/sage/pull/16 --json commits
DEBUG:root:Execute command: gh pr view https://github.com/soehms/sage/pull/16 --json labels
INFO:root:List of labels for pull request #16: ['s: needs work']

DEBUG:root:Ignore merge commit 5cd84386587dd670c61698c0d6650b360272a904 for commit_date

INFO:root:Commits until 2025-09-18T06:10:49Z for pull request #16: [{'authoredDate': '2025-09-18T06:10:49Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2025-09-18T06:10:49Z', 'messageBody': '', 'messageHeadline': 'add test line', 'oid': '7d330aabaf1073410ea139da2066f7ce493efe08'}, {'authoredDate': '2025-09-20T17:57:22Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2025-09-20T17:57:22Z', 'messageBody': '', 'messageHeadline': "Merge branch 'develop' into test_sync_labels_merge_commit", 'oid': '5cd84386587dd670c61698c0d6650b360272a904'}]
INFO:root:Proper reviews after 2025-09-18T06:10:49Z for pull request #16: [{'id': 'PRR_kwDOI72C3M7BLZGg', 'author': {'login': 'vincentmacri'}, 'authorAssociation': 'NONE', 'body': '@soehms is there where you wanted me to request changes as a test?', 'submittedAt': '2025-09-18T16:57:25Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED', 'commit': {'oid': '7d330aabaf1073410ea139da2066f7ce493efe08'}}]
INFO:root:PR pull request #16 had latest proper review at 2025-09-18T16:57:25Z: {'id': 'PRR_kwDOI72C3M7BLZGg', 'author': {'login': 'vincentmacri'}, 'authorAssociation': 'NONE', 'body': '@soehms is there where you wanted me to request changes as a test?', 'submittedAt': '2025-09-18T16:57:25Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED', 'commit': {'oid': '7d330aabaf1073410ea139da2066f7ce493efe08'}}
INFO:root:Proper reviews after 2025-09-18T06:10:49Z for pull request #16: [{'id': 'PRR_kwDOI72C3M7BLZGg', 'author': {'login': 'vincentmacri'}, 'authorAssociation': 'NONE', 'body': '@soehms is there where you wanted me to request changes as a test?', 'submittedAt': '2025-09-18T16:57:25Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED', 'commit': {'oid': '7d330aabaf1073410ea139da2066f7ce493efe08'}}]
INFO:root:PR pull request #16 had latest proper review at 2025-09-18T16:57:25Z: {'id': 'PRR_kwDOI72C3M7BLZGg', 'author': {'login': 'vincentmacri'}, 'authorAssociation': 'NONE', 'body': '@soehms is there where you wanted me to request changes as a test?', 'submittedAt': '2025-09-18T16:57:25Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED', 'commit': {'oid': '7d330aabaf1073410ea139da2066f7ce493efe08'}}

INFO:root:PR pull request #16 needs work
INFO:root:PR pull request #16 already under review (needs work)

@soehms
Copy link
Owner Author

soehms commented Sep 20, 2025

Testlog merge sync_labels_merge_commit

After I merged sync_labels_merge_commit into this branch, the s: needs_work label was replaced by s: needs review. Here is the logfile from the run:

INFO:root:cmdline_args (5) ['synchronize', 'https://github.com/soehms/sage/pull/16', 'soehms', '', '']
INFO:root:action: Action.synchronize
INFO:root:url: https://github.com/soehms/sage/pull/16
INFO:root:actor: soehms
INFO:root:label: 
INFO:root:rev_state: 
INFO:root:Create label handler for pull request #16 and actor soehms
INFO:root:version: b'gh version 2.78.0 (2025-08-21)
DEBUG:root:auth status err: b''
DEBUG:root:auth status out: b'github.com\n  \xe2\x9c\x93 Logged in to github.com account github-actions[bot] (GITHUB_TOKEN)\n  - Active account: true\n  - Git operations protocol: https\n  - Token: ghs_************************************\n'
INFO:root:Bot is github-actions
DEBUG:root:Execute command: gh api -X GET -H "Accept: application/vnd.github+json" /repos/soehms/sage/issues/comments -f per_page=100 -f page=1 -f since=2025-09-20T09:39:32Z
INFO:root:Cleaning warning comments since 2025-09-20 09:39:32.307746 (total found 1)
DEBUG:root:Execute command: gh api -X GET -H "Accept: application/vnd.github+json" /repos/soehms/sage/pulls/16/reviews -f per_page=100 -f page=1
DEBUG:root:Execute command: gh pr view https://github.com/soehms/sage/pull/16 --json isDraft
INFO:root:Issue pull request #16 is draft False
DEBUG:root:Execute command: gh pr view https://github.com/soehms/sage/pull/16 --json reviews
DEBUG:root:Reviews for pull request #16: [{'id': 'PRR_kwDOI72C3M7BLZGg', 'author': {'login': 'vincentmacri'}, 'authorAssociation': 'NONE', 'body': '@soehms is there where you wanted me to request changes as a test?', 'submittedAt': '2025-09-18T16:57:25Z', 'includesCreatedEdit': False, 'reactionGroups': [], 'state': 'CHANGES_REQUESTED', 'commit': {'oid': '7d330aabaf1073410ea139da2066f7ce493efe08'}}]
DEBUG:root:Execute command: gh pr view https://github.com/soehms/sage/pull/16 --json commits
DEBUG:root:Execute command: gh pr view https://github.com/soehms/sage/pull/16 --json labels
INFO:root:List of labels for pull request #16: ['s: needs work']

DEBUG:root:Ignore merge commit 5cd84386587dd670c61698c0d6650b360272a904 for commit_date

INFO:root:Commits until 2025-09-20T21:49:11Z for pull request #16: [{'authoredDate': '2025-09-18T06:10:49Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2025-09-18T06:10:49Z', 'messageBody': '', 'messageHeadline': 'add test line', 'oid': '7d330aabaf1073410ea139da2066f7ce493efe08'}, {'authoredDate': '2025-09-20T17:57:22Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2025-09-20T17:57:22Z', 'messageBody': '', 'messageHeadline': "Merge branch 'develop' into test_sync_labels_merge_commit", 'oid': '5cd84386587dd670c61698c0d6650b360272a904'}, {'authoredDate': '2025-09-20T21:49:11Z', 'authors': [{'email': 'seb.oehms@gmail.com', 'id': 'MDQ6VXNlcjQ3MzA1ODQ1', 'login': 'soehms', 'name': 'Sebastian'}], 'committedDate': '2025-09-20T21:49:11Z', 'messageBody': '…ommit', 'messageHeadline': "Merge branch 'sync_labels_merge_commit' into test_sync_labels_merge_c…", 'oid': 'bc74b783961ef1cb5fcc6d08ea0051e085bc7eb8'}]
INFO:root:Proper reviews after 2025-09-20T21:49:11Z for pull request #16: []
INFO:root:Proper reviews after 2025-09-20T21:49:11Z for pull request #16: []
INFO:root:PR pull request #16 doesn't need work
INFO:root:Proper reviews after 2025-09-20T21:49:11Z for pull request #16: []
INFO:root:PR pull request #16 doesn't have positve review
INFO:root:PR pull request #16 needs review
DEBUG:root:Execute command: gh --repo https://github.com/soehms/sage pr edit https://github.com/soehms/sage/pull/16 --add-label "s: needs review"
https://github.com/soehms/sage/pull/16

INFO:root:Add label to pull request #16: s: needs review

DEBUG:root:Execute command: gh --repo https://github.com/soehms/sage pr edit https://github.com/soehms/sage/pull/16 --remove-label "s: needs work"
https://github.com/soehms/sage/pull/16

INFO:root:Remove label from pull request #16: s: needs work

@soehms soehms marked this pull request as draft September 22, 2025 06:05
@soehms soehms marked this pull request as ready for review September 22, 2025 06:06
@soehms soehms requested a review from vincentmacri September 22, 2025 06:39
@vincentmacri
Copy link

@soehms What did you want me to try now?

@soehms
Copy link
Owner Author

soehms commented Sep 22, 2025

@soehms What did you want me to try now?

Nothing! Sorry for not reporting! I just tried the re-request functionality. As you can see in the Actions list the bot was not triggered (between 08:06 and 08:35).

Obviously the corresponding event is missing here:

name: Synchronize labels

on:
  issues:
    types: [opened, reopened, closed, labeled, unlabeled]
  pull_request_review:
    types: [submitted]
  pull_request_target:
    types: [opened, reopened, closed, ready_for_review, converted_to_draft, synchronize, labeled, unlabeled]
  schedule:
    # run cleaning of warning comments twice a day
    - cron: '00 6,18 * 

Thus, my assumption in sagemath#40839 (comment)

The bot should already be able to set the label.

was wrong! I would like to fix that in sagemath#40839, as well.

@soehms soehms closed this Oct 5, 2025
@soehms soehms deleted the test_sync_labels_merge_commit branch October 5, 2025 13:43
soehms pushed a commit that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants