Add unit test for provision volume workflow#28
Open
joseph-v wants to merge 3 commits intosodafoundation:masterfrom
Open
Add unit test for provision volume workflow#28joseph-v wants to merge 3 commits intosodafoundation:masterfrom
joseph-v wants to merge 3 commits intosodafoundation:masterfrom
Conversation
joseph-v
force-pushed
the
UnitTestVolumeProvision
branch
2 times, most recently
from
35e8618 to
a320c9e
Compare
joseph-v
force-pushed
the
UnitTestVolumeProvision
branch
from
a320c9e to
a6ba7dc
Compare
joseph-v
force-pushed
the
UnitTestVolumeProvision
branch
from
a6ba7dc to
56a23e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 39.53% 39.53%
=======================================
Files 13 13
Lines 683 683
Branches 71 71
=======================================
Hits 270 270
Misses 403 403
Partials 10 10 |
joseph-v
force-pushed
the
UnitTestVolumeProvision
branch
2 times, most recently
from
e7df879 to
bbc5204
Compare
joseph-v
force-pushed
the
UnitTestVolumeProvision
branch
from
bbc5204 to
7c57d84
Compare
wisererik
requested changes
May 30, 2019
| script: | ||
| - tox | ||
| - $ST2_REPO_PATH/st2common/bin/st2-run-pack-tests -p contrib/st2/opensds | ||
|
|
Collaborator
There was a problem hiding this comment.
please andd script into tox, otherwise the codecov will not caculate the coverage of unittest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR add unit tests for the opensds pack, provision volume actions
Commands to run this tests:
st2-run-pack-tests -p contrib/st2/opensds # To run all tests in opensds pack
st2-run-pack-tests -p contrib/st2/opensds -f test_action_list_volume -x -j # To run single test
Special notes for your reviewer:
Reference:
https://docs.stackstorm.com/development/pack_testing.html