Skip to content

Add config for updating image policy#490

Open
sushanthakumar wants to merge 1 commit intosodafoundation:masterfrom
sushanthakumar:patch-1
Open

Add config for updating image policy#490
sushanthakumar wants to merge 1 commit intosodafoundation:masterfrom
sushanthakumar:patch-1

Conversation

@sushanthakumar
Copy link
Copy Markdown
Collaborator

Updating image policy

What type of PR is this?

/kind enhancement

What this PR does / why we need it:
This PR improves default config for image policy

Which issue(s) this PR fixes:
This PR fixes
#485

Fixes #

Test Report Added?:

/kind TESTED

Test Report:

  1. Tested scenario1

Special notes for your reviewer:

Updating image policy
Copy link
Copy Markdown
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention why the image policy needs to be changed.

@sushanthakumar
Copy link
Copy Markdown
Collaborator Author

ase mention why the image policy needs to be changed.

Better to have default as Never

@anvithks
Copy link
Copy Markdown
Member

ase mention why the image policy needs to be changed.

Better to have default as Never

Ok. thanks.

Copy link
Copy Markdown
Member

@anvithks anvithks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
#SODACODE-PR-Accepted

Copy link
Copy Markdown
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvithks
Copy link
Copy Markdown
Member

@joseph-v I think we used this to demonstrate PR workflow at one of the SODACODE Hacker Orientations. This may not be a valid or required PR. @sushanthakumar Please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants