Fix compatibility with recent traces versions#3
Open
mjq wants to merge 1 commit intosocketry:mainfrom
Open
Conversation
`traces` version `0.5.0` introduced the `resource:` parameter to `Interface#trace`. Update the OpenTelemetry backend to accept this keyword.
mjq
commented
May 31, 2025
|
|
||
| module Interface | ||
| def trace(name, attributes: nil, &block) | ||
| def trace(name, resource: nil, attributes: nil, &block) |
Author
There was a problem hiding this comment.
I'm currently ignoring the value of resource as, as far as I can tell, there isn't an equivalent in OpenTelemetry's span data model for it like there is in DataDog's.
Merging e.g. {"resource" => resource} into the attributes hash would be another option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gem currently errors at runtime with
ArgumentError: unknown keyword: :resourcewhen used with certain instrumentation (e.g. this trace call in async-http). The gem depends ontracesversion~> 0.10, butInterface#traceis missing theresource:parameter introduced in version0.5.0. Update the interface to accept this keyword.Types of Changes
Contribution