WIP: introduces compatibility with gymnasium#34
Draft
marimeireles wants to merge 4 commits intosocialfoundations:masterfrom
Draft
WIP: introduces compatibility with gymnasium#34marimeireles wants to merge 4 commits intosocialfoundations:masterfrom
marimeireles wants to merge 4 commits intosocialfoundations:masterfrom
Conversation
marimeireles
commented
Jul 3, 2023
| id="HIV-v0", entry_point=HivEnv, apply_api_compatibility=True, max_episode_steps=400, reward_threshold=1e10, | ||
| ) | ||
|
|
||
| env = gymnasium.make("HIV-v0", apply_api_compatibility=True) |
Collaborator
Author
There was a problem hiding this comment.
This is the line I have to add so gymansium understands the environment was defined.
As mentioned in the PR body I'm not sure how to register new environments with the gymnasium API. It's a next step.
…t needs to go and code needs to be refactor so it complies to current docs
66de302 to
9510143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the work was really simple!
This is a WIP because a few features are missing even though the overall software seems to be working fine:
env = gymnasium.make("HIV-v0", apply_api_compatibility=True), this is not ideal and we should try to keep ourselves within the last API as much as possible. The reason why I'm calling there is because I don't seem able to call make in a file. I'm not entirely sure why but somehow the environment is not registered withingymnasium. If one runs:The gymnasium default environments are all listed but the whynot custom ones are not.
When I run make within an environment it works fine.