added User entity #7
Conversation
just add user entity based from the documentation. hope this is the right way to do it.
There was a problem hiding this comment.
Thanks for the contribution @ATKlegend! I left 2 comments requesting a change.
I probably should have clarified this, but you'll also need to write some tests for the User model! If you take a look at test/prosperworks/integration you'll find the general approach for testing.
| @@ -0,0 +1,12 @@ | |||
| module ProsperWorks | |||
| class User < BaseEntity | |||
There was a problem hiding this comment.
BaseEntity has more fields than the User model needs, so this should inherit instead from Base
| module ProsperWorks | ||
| class User < BaseEntity | ||
|
|
||
| attr_accessor :id, |
There was a problem hiding this comment.
Ah, and Base already declares: attr_accessor :id, so you can remove this line
|
@soccernee - Maybe you want to also have the readme updated to reflect users being a supported entity and perhaps show an example? Was gonna give the issue a shot but ATKlegend has this :) |
|
@ATKlegend: any interest in finishing this PR? Otherwise I'm inclined to give it to @keerin. |
|
@soccernee @ATKlegent Just let me know. I can get this done this weekend most likely :) |
|
Hey, I've never contributed to open source before and it doesn't look like the issue has closed; do you mind if I work on this? |
|
@dzliang100: it's all yours, go for it. Please create a separate PR, though. Thanks! |
4 participants
just add user entity based from the documentation. hope this is the right way to do it.