This repository was archived by the owner on Sep 11, 2022. It is now read-only.
backend interfaces #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcnotes
reviewed
Apr 9, 2022
src/frontend/discussions-abusefilter-app/src/interfaces/BackendInterface.ts
Outdated
Show resolved
Hide resolved
src/frontend/discussions-abusefilter-app/src/interfaces/BackendInterface.ts
Show resolved
Hide resolved
src/frontend/discussions-abusefilter-app/src/interfaces/BackendInterface.ts
Outdated
Show resolved
Hide resolved
src/frontend/discussions-abusefilter-app/src/interfaces/LocalBackendInterface.ts
Outdated
Show resolved
Hide resolved
kcnotes
approved these changes
Apr 15, 2022
|
|
||
| export interface BackendInterface { | ||
| getFilters: () => Promise<FilterMetadata[]>, | ||
| getFilter: (filterId: string) => Promise<{ filterDetails: Filter, filterMetadata: FilterMetadata }> | Error, |
Contributor
There was a problem hiding this comment.
The Error should be wrapped in Promise<>, as it's returned in the promise
Comment on lines
+14
to
+18
| createFilter: (filter: Filter, filterMetadata: FilterMetadata) => void, | ||
| updateFilter: (filter: Filter, filterMetadata: FilterMetadata) => void, | ||
| archiveFilter: (filterId: string) => void, | ||
| enableFilter: (filterId: string) => void, | ||
| disableFilter: (filterId: string) => void, |
Contributor
There was a problem hiding this comment.
These should all ideally return promises (=> Promise<void>), though it's fine to keep it as this for now. For example, we'd want to know if enabling a filter is successful or not
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.