Skip to content

fix the bug in allmotors.sms that doesn't turn solenoid sensor light on #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srswinde wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix the bug in allmotors.sms that doesn't turn solenoid sensor light on #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e659de8
Update allmotors.sms
srswinde Dec 9, 2019
0d142a8
Update gb_indi.c
srswinde Dec 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion allmotors.sms
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,7 @@ C411 ' Release the solenoid
ENDIF
WAIT=1000
OR(9)
OS(7) OS(8)
OS(7) OS(8) ' turn sol sensor on
WAIT=100
WHILE IN(6) == 1
WAIT=100
Expand All @@ -1002,6 +1002,7 @@ C411 ' Release the solenoid
' or when we move filter wheels (GOSUB400)
AT:FWHEEL_UPPER=0
AT:FWHEEL_LOWER=0
OR(7) OR(8) ' turn sol sensor off
IF DEBUG PRINT("SOLENOID RELEASED", #13) ENDIF

RETURN
Expand Down
7 changes: 4 additions & 3 deletions gb_indi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1447,7 +1447,7 @@ static int guiderTelem(int init_struct)
}
IDSetSwitch(&lfSP, NULL);

fwheel_lower_isOff =motor->words[0] & 2;
//fwheel_lower_isOff =motor->words[0] & 2;
}

else if( !strcmp( motor->name, "FWHEEL_UPPER" ) )
Expand All @@ -1474,7 +1474,7 @@ static int guiderTelem(int init_struct)
}
IDSetSwitch(&ufSP, NULL);

fwheel_upper_isOff = motor->words[0] & 2;
//fwheel_upper_isOff = motor->words[0] & 2;

}
else if( !strcmp( motor->name, "OFFSET_FWHEEL" ) )
Expand Down Expand Up @@ -1557,6 +1557,7 @@ static int guiderTelem(int init_struct)

//solenoid sensor stays on due to bug in firmware
//we shall fix it here until the firmware is fixed.
/*
if(fwheel_lower_isOff && fwheel_upper_isOff)
{
if( solenoid_status == ON )
Expand All @@ -1571,7 +1572,7 @@ static int guiderTelem(int init_struct)
{
IDMessage(mydev, "FHWEELS ON");
solenoid_status = ON;
}
}*/

//fprintf(stderr, "in guiderTelem %s\n", allmotors[5].name );
return 1;
Expand Down