-
Notifications
You must be signed in to change notification settings - Fork 28
Typed file-embed #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
L0neGamer
wants to merge
16
commits into
snoyberg:master
Choose a base branch
from
L0neGamer:typed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Typed file-embed #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we'll use these as the workhorse for the main file
Author
|
I've had a brief search of hackage, and found at least one place where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I split Data.FileEmbed into three modules:
Typed,RelativePath, andInjection. The intent is thatRelativePathcontainsmakeRelativeToProjectandmakeRelativeToLocationPredicate,Injectioncontains all the functions to do with injecting data, andTypedcontains typed template haskell function variants of the originalData.FileEmbedmodule. These are all then exported fromData.FileEmbed, and in the case ofTypedturned into non-typed variants to maintain the existing API.As part of this I also get rid of some unused, incredibly simple utility functions. These can be restored easily if need be.These have been restored.Were it not for the removed functions above, I believe this wouldn't be a breaking change - the API is maintained. Increasing the lower bounds means that older projects won't even try and obtain this version, meaning that we're free to use modern template-haskell.To add the relevant warnings for internals functions, the minimum GHC we're permitted is 9.8