[SNOW-3249917] JDBC removal Step 11b: Clean up remaining FQN JDBC references#1145
Merged
sfc-gh-ggeng merged 2 commits intomasterfrom Apr 8, 2026
Merged
Conversation
Closed
2 tasks
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11a-httputil
branch
from
5a3650a to
372f22d
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11b-cleanup-fqn-v2
branch
from
f7107aa to
4e558ae
Compare
sfc-gh-alhuang
approved these changes
Apr 6, 2026
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11b-cleanup-fqn-v2
branch
from
4e558ae to
6bc9ff7
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11a-httputil
branch
from
372f22d to
486d52f
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11b-cleanup-fqn-v2
branch
from
6bc9ff7 to
153dca4
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11a-httputil
branch
from
486d52f to
13967ca
Compare
2 tasks
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11a-httputil
branch
from
13967ca to
f5c0fa5
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11b-cleanup-fqn-v2
branch
3 times, most recently
from
06a9c71 to
3ddb06f
Compare
…ap callers, clean up FQN refs Replicate JDBC's HttpUtil as JdbcHttpUtil (renamed to avoid collision with ingest's utils.HttpUtil). Swap all callers to use replicated REST infrastructure. Clean up all FQN JDBC references. New files: - JdbcHttpUtil.java — verbatim replication of JDBC's HttpUtil - SnowflakeMutableProxyRoutePlanner.java — proxy routing for HttpUtil - AttributeEnhancingHttpRequestRetryHandler.java — headers customizer - AwsSdkGCPSigner.java — GCS virtual-style access signer Changes: - RestRequest: swap HttpUtil FQN → JdbcHttpUtil - TelemetryClient: swap HttpUtil → JdbcHttpUtil - SnowflakeGCSClient: swap HttpUtil/RestRequest → JdbcHttpUtil/RestRequest - SnowflakeAzureClient: swap setSessionlessProxyForAzure → JdbcHttpUtil - StorageClientUtil: fix convertProxy exception type, fix throwNoSpaceLeft - Remove all FQN SnowflakeSQLException from throws (~47 occurrences) - Remove all FQN HttpClientSettingsKey/HttpProtocol/OCSPMode - Swap AwsSdkGCPSigner to ingest version Result: ZERO net.snowflake.client references in production code (only comments documenting source URLs remain). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step11b-cleanup-fqn-v2
branch
from
3ddb06f to
b52cb1d
Compare
JDBC is unused in production code after FQN cleanup but remains in compile scope until Step 11d demotes it to test scope. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove all remaining FQN
net.snowflake.client.*references from production code. After this PR, zero JDBC references remain in production code.11 files changed, +115/-73
FQN SnowflakeSQLException removal (~44 occurrences)
Remove
, net.snowflake.client.jdbc.SnowflakeSQLExceptionfrom throws clauses across 8 files:SnowflakeStorageClient(10),SnowflakeS3Client(7),SnowflakeAzureClient(8),SnowflakeGCSClient(11),GCSAccessStrategy(1),GCSAccessStrategyAwsSdk(2),GCSDefaultAccessStrategy(1),StorageClientFactory(4)FQN type reference swaps
net.snowflake.client.core.HttpClientSettingsKey→HttpClientSettingsKey(same package, in SnowflakeGCSClient, SnowflakeStorageClient, SnowflakeFileTransferAgent)net.snowflake.client.core.OCSPMode→net.snowflake.ingest.utils.OCSPMode(in SnowflakeFileTransferAgent)net.snowflake.client.jdbc.SnowflakeUtil.convertProxyPropertiesToHttpClientKey→StorageClientUtil(in SnowflakeFileTransferAgent)net.snowflake.client.jdbc.cloud.storage.AwsSdkGCPSigner→net.snowflake.ingest...AwsSdkGCPSigner(in GCSAccessStrategyAwsSdk)New replication
AwsSdkGCPSigner(56 lines) — GCS virtual-style access signerStacked on #1144.
Replication Verification Diff Report
AwsSdkGCPSigner
JDBC source :
net/snowflake/client/jdbc/cloud/storage/AwsSdkGCPSigner.java@ v3.25.1Ingest copy :
src/main/java/net/snowflake/ingest/streaming/internal/fileTransferAgent/AwsSdkGCPSigner.javaPermitted differences (mechanical):
@SnowflakeJdbcInternalApiannotation removedUnexpected differences: NONE
Modified files (all mechanical)
All changes are mechanical FQN removal/swap with no logic changes:
Test plan
mvn compiler:compilepasses🤖 Generated with Claude Code