[SNOW-3249917] JDBC removal Step 10b: Swap SFException imports#1134
Merged
sfc-gh-ggeng merged 2 commits intomasterfrom Apr 2, 2026
Merged
[SNOW-3249917] JDBC removal Step 10b: Swap SFException imports#1134sfc-gh-ggeng merged 2 commits intomasterfrom
sfc-gh-ggeng merged 2 commits intomasterfrom
Conversation
sfc-gh-alhuang
approved these changes
Apr 2, 2026
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step10a-replicate-remaining
branch
from
279c755 to
939fdf3
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step10b-swap-remaining
branch
2 times, most recently
from
b5ccf78 to
72f5e83
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step10a-replicate-remaining
branch
from
939fdf3 to
99b0353
Compare
Base automatically changed from
jdbc-removal-step10a-replicate-remaining
to
master
April 2, 2026 19:46
Mechanical import swaps — remove SFException JDBC imports from files where the replicated SFException is now in the same package: - SnowflakeSQLException: remove import (SFException in same package) - SnowflakeSQLLoggedException: remove import (SFException in same package) - TelemetryEvent: remove import (SFException in same package) ExecTimeTelemetryData and HttpResponseContextDto imports in SnowflakeGCSClient NOT swapped — they interact with JDBC's RestRequest.executeWithRetries() which expects JDBC types. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Steps 1-9a, 9b-prep: MERGED - Steps 9b, 9c, 10a, 10b: Open with PRs - Step 10c: Remove SFSession/SFBaseSession (always null, not replicable) - Step 10d: Demote JDBC to test scope (27 remaining imports with massive dependency chains) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step10b-swap-remaining
branch
from
72f5e83 to
0cd4046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical import swaps — remove SFException JDBC imports from files where the replicated SFException is now in the same package:
SnowflakeSQLException: removeimport net.snowflake.client.core.SFException(same package)SnowflakeSQLLoggedException: removeimport net.snowflake.client.core.SFException(same package)TelemetryEvent: removeimport net.snowflake.client.core.SFException(same package)ExecTimeTelemetryDataandHttpResponseContextDtoimports inSnowflakeGCSClientNOT swapped — they interact with JDBC'sRestRequest.executeWithRetries()which expects JDBC types.Diff report
All changes are mechanical import removals (class now in same package).
Unexpected differences: NONE
Test plan
mvn compiler:compilepasses🤖 Generated with Claude Code