[SNOW-3249917] JDBC removal Step 9c: Swap telemetry imports#1131
Merged
sfc-gh-ggeng merged 1 commit intomasterfrom Apr 2, 2026
Merged
[SNOW-3249917] JDBC removal Step 9c: Swap telemetry imports#1131sfc-gh-ggeng merged 1 commit intomasterfrom
sfc-gh-ggeng merged 1 commit intomasterfrom
Conversation
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9b-oob-telemetry
branch
from
28d3946 to
8ec5aef
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9c-swap-telemetry-imports
branch
from
83162e8 to
94fd850
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9b-oob-telemetry
branch
from
8ec5aef to
e709177
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9c-swap-telemetry-imports
branch
2 times, most recently
from
5943e3a to
c9fad98
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9b-oob-telemetry
branch
2 times, most recently
from
17ac99f to
64def8a
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9c-swap-telemetry-imports
branch
from
c9fad98 to
08529fb
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9b-oob-telemetry
branch
from
64def8a to
69595b0
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9c-swap-telemetry-imports
branch
2 times, most recently
from
783bfbc to
6f83093
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9b-oob-telemetry
branch
2 times, most recently
from
835508d to
f4bb6b5
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9c-swap-telemetry-imports
branch
from
6f83093 to
53fa30c
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9b-oob-telemetry
branch
from
f4bb6b5 to
43f0c5d
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9c-swap-telemetry-imports
branch
2 times, most recently
from
71eab2a to
1cb88ff
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9b-oob-telemetry
branch
from
43f0c5d to
6aa92e0
Compare
sfc-gh-alhuang
approved these changes
Apr 2, 2026
Mechanical import swaps only — no logic changes: SnowflakeSQLLoggedException (6 of 12 JDBC imports swapped): - ObjectMapperFactory → same package (already replicated) - SqlState → same package (already replicated) - TelemetryEvent → same package (replicated in Step 9b) - TelemetryService (OOB) → same package (replicated in Step 9b) - LoginInfoDTO.SF_JDBC_APP_ID → SnowflakeDriverConstants.SF_JDBC_APP_ID - SnowflakeDriver.implementVersion → SnowflakeDriverConstants.implementVersion Kept from JDBC: SFBaseSession, SFSession, SFException (parameter types), Telemetry, TelemetryField, TelemetryUtil (interact with session.getTelemetryClient()) TelemetryClient (1 of 5 JDBC imports swapped): - TelemetryThreadPool → ingest version (replicated in Step 9b) Kept from JDBC: HttpUtil, SFSession, SnowflakeConnectionV1, SnowflakeSQLException Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step9c-swap-telemetry-imports
branch
from
1cb88ff to
63cdb21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical import swaps only — no logic changes, no method removal:
SnowflakeSQLLoggedException (6 of 12 JDBC imports swapped):
ObjectMapperFactory→ same packageSqlState→ same packageTelemetryEvent→ same package (replicated in Step 9b)TelemetryService(OOB) → same package (replicated in Step 9b)LoginInfoDTO.SF_JDBC_APP_ID→SnowflakeDriverConstants.SF_JDBC_APP_IDSnowflakeDriver.implementVersion→SnowflakeDriverConstants.implementVersionKept from JDBC (6):
SFBaseSession,SFSession,SFException(parameter types),Telemetry,TelemetryField,TelemetryUtil(interact withsession.getTelemetryClient()which returns JDBC types)TelemetryClient (1 of 5 JDBC imports swapped):
TelemetryThreadPool→ ingest version (replicated in Step 9b)Kept from JDBC (4):
HttpUtil,SFSession,SnowflakeConnectionV1,SnowflakeSQLExceptionTest plan
mvn compiler:compilepasses🤖 Generated with Claude Code