Skip to content

SNOW-2395738 Expose tokenFilePath in Config, read it for every new connection #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sfc-gh-pfus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SNOW-2395738 Expose tokenFilePath in Config, read it for every new connection #1666

sfc-gh-pfus wants to merge 1 commit into from
+256 −36

Conversation

@sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 23, 2025 •
edited
Loading

Description

SNOW-2395738 Expose tokenFilePath in Config, read it for every new connection

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 23, 2025 12:26
@codecov
Copy link

codecov bot commented Dec 23, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3312 1 3311 83
View the full list of 3 ❄️ flaky test(s) 
github.com/snowflakedb/gosnowflake::TestLoadConnectionConfigWithTokenFileNotExist

Flake rate in main: 3.85% (Passed 25 times, Failed 1 times)

Stack Traces | 0s run time 
Failed
github.com/snowflakedb/gosnowflake::TestMfaParallelLogin

Flake rate in main: 5.56% (Passed 17 times, Failed 1 times)

Stack Traces | 10.5s run time 
Failed
github.com/snowflakedb/gosnowflake::TestMfaParallelLogin/starts_without_mfa_token,_singleAuthenticationPrompt=false

Flake rate in main: 3.33% (Passed 29 times, Failed 1 times)

Stack Traces | 2.07s run time 
Failed

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-2395738-token-file-path branch from 0c8c92b to 72d72c9 Compare December 23, 2025 13:03
@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-2395738-token-file-path branch from 72d72c9 to 07df7ce Compare December 23, 2025 14:02
sfc-gh-merbel
sfc-gh-merbel approved these changes Dec 23, 2025
View reviewed changes
auth.go
requestMain.Authenticator = AuthTypeOAuth.String()
requestMain.Token = sc.cfg.Token
var err error
if requestMain.Token, err = sc.cfg.getToken(); err != nil {
Copy link

@sfc-gh-merbel sfc-gh-merbel Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: sc.cfg.getToken() or sc.cfg.Token ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-merbel sfc-gh-merbel sfc-gh-merbel approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-pfus @sfc-gh-merbel