SNOW-2465270 Add CGO_ENABLED marker to telemetry #1664
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
force-pushed
the
SNOW-2465270-cgo-enabled
branch
from
e168e87 to
291f69a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1664 +/- ##
==========================================
- Coverage 80.87% 80.85% -0.03%
==========================================
Files 74 74
Lines 17807 17809 +2
==========================================
- Hits 14401 14399 -2
- Misses 3406 3410 +4 ☔ View full report in Codecov by Sentry. |
sfc-gh-boler
reviewed
Jan 5, 2026
|
|
||
| package cgo | ||
|
|
||
| var _ = func() any { |
There was a problem hiding this comment.
I think it would be slightly cleaner to have cgo_enabled.go and cgo_not_enabled.go with inverse tags, instead of depending on initialization order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-2465270 Add CGO_ENABLED marker to telemetry
Checklist